[GitHub] [iceberg] stevenzwu commented on a change in pull request #1956: upgrade flink version from 1.11.0 to 1.12.0

[GitBox <gi...@apache.org>]

stevenzwu commented on a change in pull request #1956:
URL: https://github.com/apache/iceberg/pull/1956#discussion_r551683365



##########
File path: flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScanSql.java
##########
@@ -52,12 +53,25 @@ public TestFlinkScanSql(String fileFormat) {
   @Override
   public void before() throws IOException {
     super.before();
-    tEnv = TableEnvironment.create(EnvironmentSettings.newInstance().useBlinkPlanner().inBatchMode().build());
-    tEnv.executeSql(String.format(
+    getTableEnv().executeSql(String.format(

Review comment:
       this is to avoid creating the table environment for each test method. it is the same pattern used by `FlinkTestBase`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org