You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "TianYu (JIRA)" <ji...@apache.org> on 2009/06/19 04:51:07 UTC
[jira] Created: (HARMONY-6239) [classlib][text]text module doesn't
need to import java.awt.font while the manifest.mf file does
[classlib][text]text module doesn't need to import java.awt.font while the manifest.mf file does
------------------------------------------------------------------------------------------------
Key: HARMONY-6239
URL: https://issues.apache.org/jira/browse/HARMONY-6239
Project: Harmony
Issue Type: Improvement
Components: Classlib
Affects Versions: 5.0M10
Environment: all
Reporter: TianYu
Priority: Trivial
Fix For: 5.0M10
I noticed that text.jar imports java.awt.font in its manifest.mf .
After some research , I only find the following in text.jar ( Bidi )
* @see java.awt.font.TextAttribute#BIDI_EMBEDDING
* @see java.awt.font.TextAttribute#NUMERIC_SHAPING
* @see java.awt.font.TextAttribute#RUN_DIRECTION
*/
so I think better to delete the line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6239) [classlib][text]text module doesn't
need to import java.awt.font while the manifest.mf file does
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess updated HARMONY-6239:
----------------------------------
Fix Version/s: (was: 5.0M10)
5.0M11
Can't very well be fixed in the same version it is broken in but I'm sure we can fix it before M11. ;-)
> [classlib][text]text module doesn't need to import java.awt.font while the manifest.mf file does
> ------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6239
> URL: https://issues.apache.org/jira/browse/HARMONY-6239
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M10
> Environment: all
> Reporter: TianYu
> Assignee: Mark Hindess
> Priority: Trivial
> Fix For: 5.0M11
>
> Attachments: diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> I noticed that text.jar imports java.awt.font in its manifest.mf .
> After some research , I only find the following in text.jar ( Bidi )
> * @see java.awt.font.TextAttribute#BIDI_EMBEDDING
> * @see java.awt.font.TextAttribute#NUMERIC_SHAPING
> * @see java.awt.font.TextAttribute#RUN_DIRECTION
> */
> so I think better to delete the line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6239) [classlib][text]text module
doesn't need to import java.awt.font while the manifest.mf file does
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722180#action_12722180 ]
Tim Ellison commented on HARMONY-6239:
--------------------------------------
The javadoc comment needs to be fixed too, or else we get errors about invalid references (which is why the import was added int h first place).
I agree with not putting a module dependency on AWT purely for javadoc reasons, but when we remove it we also need to remove the cause of the dependency.
> [classlib][text]text module doesn't need to import java.awt.font while the manifest.mf file does
> ------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6239
> URL: https://issues.apache.org/jira/browse/HARMONY-6239
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M10
> Environment: all
> Reporter: TianYu
> Assignee: Mark Hindess
> Priority: Trivial
> Fix For: 5.0M11
>
> Attachments: diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> I noticed that text.jar imports java.awt.font in its manifest.mf .
> After some research , I only find the following in text.jar ( Bidi )
> * @see java.awt.font.TextAttribute#BIDI_EMBEDDING
> * @see java.awt.font.TextAttribute#NUMERIC_SHAPING
> * @see java.awt.font.TextAttribute#RUN_DIRECTION
> */
> so I think better to delete the line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6239) [classlib][text]text module doesn't
need to import java.awt.font while the manifest.mf file does
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess reassigned HARMONY-6239:
-------------------------------------
Assignee: Mark Hindess
> [classlib][text]text module doesn't need to import java.awt.font while the manifest.mf file does
> ------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6239
> URL: https://issues.apache.org/jira/browse/HARMONY-6239
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M10
> Environment: all
> Reporter: TianYu
> Assignee: Mark Hindess
> Priority: Trivial
> Fix For: 5.0M10
>
> Attachments: diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> I noticed that text.jar imports java.awt.font in its manifest.mf .
> After some research , I only find the following in text.jar ( Bidi )
> * @see java.awt.font.TextAttribute#BIDI_EMBEDDING
> * @see java.awt.font.TextAttribute#NUMERIC_SHAPING
> * @see java.awt.font.TextAttribute#RUN_DIRECTION
> */
> so I think better to delete the line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6239) [classlib][text]text module doesn't
need to import java.awt.font while the manifest.mf file does
Posted by "TianYu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
TianYu updated HARMONY-6239:
----------------------------
Attachment: diff
> [classlib][text]text module doesn't need to import java.awt.font while the manifest.mf file does
> ------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6239
> URL: https://issues.apache.org/jira/browse/HARMONY-6239
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M10
> Environment: all
> Reporter: TianYu
> Priority: Trivial
> Fix For: 5.0M10
>
> Attachments: diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> I noticed that text.jar imports java.awt.font in its manifest.mf .
> After some research , I only find the following in text.jar ( Bidi )
> * @see java.awt.font.TextAttribute#BIDI_EMBEDDING
> * @see java.awt.font.TextAttribute#NUMERIC_SHAPING
> * @see java.awt.font.TextAttribute#RUN_DIRECTION
> */
> so I think better to delete the line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6239) [classlib][text]text module doesn't
need to import java.awt.font while the manifest.mf file does
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess resolved HARMONY-6239.
-----------------------------------
Resolution: Fixed
Thanks very much for pointing this out. I've applied your patch in commit r786652. Please confirm it has been applied as expected.
For future reference, please note that it is preferred that patches be made using svn diff from the top-level of the federated build, the top-level of the component (classlib/jdktools), or from within a module - i.e. relative to a directory with a Harmony build.xml in it. Thanks.
> [classlib][text]text module doesn't need to import java.awt.font while the manifest.mf file does
> ------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6239
> URL: https://issues.apache.org/jira/browse/HARMONY-6239
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Affects Versions: 5.0M10
> Environment: all
> Reporter: TianYu
> Assignee: Mark Hindess
> Priority: Trivial
> Fix For: 5.0M11
>
> Attachments: diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> I noticed that text.jar imports java.awt.font in its manifest.mf .
> After some research , I only find the following in text.jar ( Bidi )
> * @see java.awt.font.TextAttribute#BIDI_EMBEDDING
> * @see java.awt.font.TextAttribute#NUMERIC_SHAPING
> * @see java.awt.font.TextAttribute#RUN_DIRECTION
> */
> so I think better to delete the line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.