You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/04/14 18:22:25 UTC
Review Request 72363: Fixed handling disconnected agents by
REACTIVATE_AGENT call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72363/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Greg Mann.
Bugs: MESOS-10116
https://issues.apache.org/jira/browse/MESOS-10116
Repository: mesos
Description
-------
This patch fixes MESOS-10116 by preventing REACTIVATE_AGENT from
activating disconnected agents in allocator and also fixes handling
agents that were removed while the reactivation was being stored into
registry.
Diffs
-----
src/master/http.cpp c51d9fd714d1cc2acc008c619a612d6838650176
src/master/master.hpp a57237d81bfd979a6ddaf6016389ca365f414917
src/master/master.cpp a8cca622ff0bd172300b9a2717b4860ed06b620c
Diff: https://reviews.apache.org/r/72363/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72363: Fixed handling disconnected agents by
REACTIVATE_AGENT call.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72363/#review220317
-----------------------------------------------------------
Ship it!
In the description:
s/in allocator/in the allocator/
s/fixes handling agents/fixes the handling of agents/
s/into registry/into the registry/
- Greg Mann
On April 14, 2020, 6:22 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72363/
> -----------------------------------------------------------
>
> (Updated April 14, 2020, 6:22 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Greg Mann.
>
>
> Bugs: MESOS-10116
> https://issues.apache.org/jira/browse/MESOS-10116
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes MESOS-10116 by preventing REACTIVATE_AGENT from
> activating disconnected agents in allocator and also fixes handling
> agents that were removed while the reactivation was being stored into
> registry.
>
>
> Diffs
> -----
>
> src/master/http.cpp c51d9fd714d1cc2acc008c619a612d6838650176
> src/master/master.hpp a57237d81bfd979a6ddaf6016389ca365f414917
> src/master/master.cpp a8cca622ff0bd172300b9a2717b4860ed06b620c
>
>
> Diff: https://reviews.apache.org/r/72363/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72363: Fixed handling disconnected agents by
REACTIVATE_AGENT call.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72363/
-----------------------------------------------------------
(Updated May 4, 2020, 12:37 p.m.)
Review request for mesos, Benjamin Mahler and Greg Mann.
Changes
-------
Fixed articles in description.
Bugs: MESOS-10116
https://issues.apache.org/jira/browse/MESOS-10116
Repository: mesos
Description (updated)
-------
This patch fixes MESOS-10116 by preventing REACTIVATE_AGENT from
activating disconnected agents in the allocator and also fixes the
handling of agents that were removed while the reactivation was being
stored into the registry.
Diffs (updated)
-----
src/master/http.cpp c51d9fd714d1cc2acc008c619a612d6838650176
src/master/master.hpp a57237d81bfd979a6ddaf6016389ca365f414917
src/master/master.cpp a8cca622ff0bd172300b9a2717b4860ed06b620c
Diff: https://reviews.apache.org/r/72363/diff/2/
Changes: https://reviews.apache.org/r/72363/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko