You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2010/03/14 02:30:27 UTC
[jira] Resolved: (MATH-336) Unnecessary null checks in equals
methods
[ https://issues.apache.org/jira/browse/MATH-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved MATH-336.
-----------------------
Resolution: Fixed
Fixed as part of MATH-337
> Unnecessary null checks in equals methods
> -----------------------------------------
>
> Key: MATH-336
> URL: https://issues.apache.org/jira/browse/MATH-336
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Sebb
> Priority: Minor
> Fix For: 2.1
>
>
> Many of the equals() methods have code like the following:
> {code}
> if (obj == null) {
> return false;
> }
> if (!(obj instanceof OpenMapRealVector)) {
> return false;
> }
> {code}
> The null check is redundant, as null would cause the instanceof check to fail anyway, so the null check could just be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.