You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/31 06:15:06 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #23216: Fix PipelineDataSourceConfiguration side effect
sandynz opened a new pull request, #23216:
URL: https://github.com/apache/shardingsphere/pull/23216
Changes proposed in this pull request:
- Fix PipelineDataSourceConfiguration side effect
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #23216: Fix PipelineDataSourceConfiguration side effect
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #23216:
URL: https://github.com/apache/shardingsphere/pull/23216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23216: Fix PipelineDataSourceConfiguration side effect
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23216:
URL: https://github.com/apache/shardingsphere/pull/23216#issuecomment-1368174248
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23216?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23216](https://codecov.io/gh/apache/shardingsphere/pull/23216?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c05151) into [master](https://codecov.io/gh/apache/shardingsphere/commit/77325f0bbfac48070efb668dec8250b314f79bec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77325f0) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #23216 +/- ##
============================================
- Coverage 49.74% 49.73% -0.01%
- Complexity 2441 2453 +12
============================================
Files 4016 4019 +3
Lines 57440 57506 +66
Branches 9113 9123 +10
============================================
+ Hits 28573 28602 +29
- Misses 26332 26367 +35
- Partials 2535 2537 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ShardingSpherePipelineDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2FwaS9kYXRhc291cmNlL2NvbmZpZy9pbXBsL1NoYXJkaW5nU3BoZXJlUGlwZWxpbmVEYXRhU291cmNlQ29uZmlndXJhdGlvbi5qYXZh) | `63.88% <100.00%> (+13.88%)` | :arrow_up: |
| [.../impl/StandardPipelineDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2FwaS9kYXRhc291cmNlL2NvbmZpZy9pbXBsL1N0YW5kYXJkUGlwZWxpbmVEYXRhU291cmNlQ29uZmlndXJhdGlvbi5qYXZh) | `78.94% <100.00%> (ø)` | |
| [...e/plugin/advisor/AdvisorConfigurationRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/23216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vYWR2aXNvci9BZHZpc29yQ29uZmlndXJhdGlvblJlZ2lzdHJ5LmphdmE=) | `100.00% <0.00%> (ø)` | |
| [...stsql/parser/core/MaskDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/23216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvbWFzay9kaXN0c3FsL3BhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWFzay9kaXN0c3FsL3BhcnNlci9jb3JlL01hc2tEaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ateDatabaseDiscoveryHeartbeatStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9DcmVhdGVEYXRhYmFzZURpc2NvdmVyeUhlYXJ0YmVhdFN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `65.00% <0.00%> (ø)` | |
| [.../CreateReadwriteSplittingRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvcmVhZHdyaXRlLXNwbGl0dGluZy9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0NyZWF0ZVJlYWR3cml0ZVNwbGl0dGluZ1J1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `68.75% <0.00%> (ø)` | |
| [...rithm/replace/TelephoneRandomReplaceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/23216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvbWFzay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tYXNrL2FsZ29yaXRobS9yZXBsYWNlL1RlbGVwaG9uZVJhbmRvbVJlcGxhY2VBbGdvcml0aG0uamF2YQ==) | `92.00% <0.00%> (ø)` | |
| [.../mask/distsql/handler/query/MaskRuleResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/23216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvbWFzay9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21hc2svZGlzdHNxbC9oYW5kbGVyL3F1ZXJ5L01hc2tSdWxlUmVzdWx0U2V0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../distsql/handler/query/CountMaskRuleResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/23216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvbWFzay9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21hc2svZGlzdHNxbC9oYW5kbGVyL3F1ZXJ5L0NvdW50TWFza1J1bGVSZXN1bHRTZXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...re/infra/util/spi/ShardingSphereServiceLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9zcGkvU2hhcmRpbmdTcGhlcmVTZXJ2aWNlTG9hZGVyLmphdmE=) | `95.83% <0.00%> (+0.18%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/shardingsphere/pull/23216/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org