You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/07/02 07:50:17 UTC
Review Request: Updated 'strings::format' to "stringify" arguments that are
not POD types.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5691/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Description
-------
Pulled this out of the "paths" review and updated it to "stringify" non-POD types.
Diffs
-----
src/Makefile.am 8760f59
src/common/format.hpp PRE-CREATION
src/common/strings.hpp 37685bb
Diff: https://reviews.apache.org/r/5691/diff/
Testing
-------
Thanks,
Benjamin Hindman
Re: Review Request: Updated 'strings::format' to "stringify" arguments that
are not POD types.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 2, 2012, 5:55 p.m., Vinod Kone wrote:
> > src/common/format.hpp, line 309
> > <https://reviews.apache.org/r/5691/diff/1/?file=117753#file117753line309>
> >
> > why this specialization?
Just an optimization (no call to stringify).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5691/#review8804
-----------------------------------------------------------
On July 2, 2012, 5:50 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5691/
> -----------------------------------------------------------
>
> (Updated July 2, 2012, 5:50 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> Pulled this out of the "paths" review and updated it to "stringify" non-POD types.
>
>
> Diffs
> -----
>
> src/Makefile.am 8760f59
> src/common/format.hpp PRE-CREATION
> src/common/strings.hpp 37685bb
>
> Diff: https://reviews.apache.org/r/5691/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Updated 'strings::format' to "stringify" arguments that
are not POD types.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5691/#review8804
-----------------------------------------------------------
Ship it!
Ship It!
src/common/format.hpp
<https://reviews.apache.org/r/5691/#comment18625>
this is swell
src/common/format.hpp
<https://reviews.apache.org/r/5691/#comment18626>
why this specialization?
- Vinod Kone
On July 2, 2012, 5:50 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5691/
> -----------------------------------------------------------
>
> (Updated July 2, 2012, 5:50 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> Pulled this out of the "paths" review and updated it to "stringify" non-POD types.
>
>
> Diffs
> -----
>
> src/Makefile.am 8760f59
> src/common/format.hpp PRE-CREATION
> src/common/strings.hpp 37685bb
>
> Diff: https://reviews.apache.org/r/5691/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>