[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1257: [NETBEANS-132] Docker support: add inspect & process list actions

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #1257: [NETBEANS-132] Docker support: add inspect & process list actions
URL: https://github.com/apache/netbeans/pull/1257#discussion_r320869468
 
 

 ##########
 File path: ide/docker.ui/src/org/netbeans/modules/docker/ui/JsonFormattingWriter.java
 ##########
 @@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.docker.ui;
+
+import java.io.StringWriter;
+
+/**
+ *
+ * @author ihsahn
+ */
+public class JsonFormattingWriter extends StringWriter {
+
+    private int indent = 0;
+    private final int indentationWidth;
+
+    public JsonFormattingWriter(int indentationWidth) {
+        this.indentationWidth = indentationWidth;
+    }
+
+    @Override
+    public void write(int c) {
 
 Review comment:
   This method is broken. the characters, that are switched on below are valid content for strings, this writer will destroy/damage such strings. We have a full blown JSON parser, that can handle reformatting, I would use that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists