You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by "divijvaidya (GitHub)" <gi...@apache.org> on 2019/12/06 08:02:39 UTC

[GitHub] [tinkerpop] divijvaidya commented on issue #1226: Set requestId and userAgent in byte code request when they are available in requestOptions

Thanks for making this change. And congratulations on your first change to this project 🎉

A test would be very helpful as it would catch unexpected regressions in future. You would probably want to add the test here: https://github.com/apache/tinkerpop/blob/master/gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteConnectionTest.java
OR
add an integration test over here: https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java

Also, can you please rebase you change against the 34 branch instead of the master? (since we would want to push this fix out with 3.4.x series)

[ Full content available at: https://github.com/apache/tinkerpop/pull/1226 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org