You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 00:15:02 UTC
[PR] fix(i18n): localize demo alert rule names and durations [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3176:
URL: https://github.com/apache/rocketmq-dashboard/pull/3176
### Summary
Localize the demo (mock-mode) alert rule names and durations for English UI:
- `AlertRule` gains optional `enName` / `enDuration`; all 8 demo rules (`mock/alerts.ts`) now carry English name and duration copy.
- The alert rules table renders those when the UI language is English, falling back to the Chinese values otherwise (sorting still uses the stored values).
### Why
In demo mode the alert rules list still showed Chinese rule names/durations in English UI.
### Testing
- `tsc --noEmit` passes (exit 0).
- `eslint` clean on changed files (0 errors; 5 pre-existing warnings remain).
- Vitest: full `AlertsPage` suite passes (20/20, default-zh assertions unchanged).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(i18n): localize demo alert rule names and durations [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3176: fix(i18n): localize demo alert rule names and durations
URL: https://github.com/apache/rocketmq-dashboard/pull/3176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org