You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2018/12/03 21:22:03 UTC
[jira] [Resolved] (ARROW-3842) [R] RecordBatchStreamWriter api
[ https://issues.apache.org/jira/browse/ARROW-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wes McKinney resolved ARROW-3842.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.12.0
Issue resolved by pull request 3043
[https://github.com/apache/arrow/pull/3043]
> [R] RecordBatchStreamWriter api
> -------------------------------
>
> Key: ARROW-3842
> URL: https://issues.apache.org/jira/browse/ARROW-3842
> Project: Apache Arrow
> Issue Type: New Feature
> Components: R
> Reporter: Romain François
> Assignee: Romain François
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.12.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> To support the "Writing and Reading Streams" section of the vignette, perhaps we should rely more on the RecordBatchStreamWriter class and less the `write_record_batch` function.
> We should be able to write code resembling the python api :
> {code:r}
> batch <- ...
> sink <- buffer_output_stream()
> writer <- record_batch_stream_writer(sink, batch$schema())
> writer$write_batch()
> writer$close()
> sink$getvalue()
> {code}
> Most of the code is there, but we need to add
> - RecordBatchStreamWriter$write_batch() : write a record batch to the stream. We already have RecordBatchStreamWriter$WriteRecordBatch
> - RecordBatchStreamWriter$close() : not sure why it is lower case close() in python but upper case in C++. We already have RecordBatchWriter$Close()
> - BufferOutputStream$getvalue() : we already have BufferOutputStream$Finish()
> Currently the constructor for a BufferOutputStream is buffer_output_stream(), perhaps we can align with python and make it BufferOutputStream, that would not clash with the `arrow::BufferOutputStream` class because of the namespacing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)