You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/05/05 07:45:05 UTC
[GitHub] [ignite-3] ibessonov commented on a diff in pull request #775: IGNITE-16848 BinaryTuple interface extracted from Row.
ibessonov commented on code in PR #775:
URL: https://github.com/apache/ignite-3/pull/775#discussion_r865633936
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/row/BinaryTuple.java:
##########
@@ -0,0 +1,223 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.schema.row;
+
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.time.Instant;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.util.BitSet;
+import java.util.UUID;
+import org.apache.ignite.internal.schema.InvalidTypeException;
+
+/**
+ * General interface to describe binary tuples outside of their data layout and column schemas.
+ * Accessor methods may or may not throw {@link InvalidTypeException} depending on the implementation.
+ */
+public interface BinaryTuple {
+ /**
+ * Returns a number of values in the tuple.
+ */
+ int count();
+
+ /**
+ * Checks whether the given column contains a null value.
+ *
+ * @param col Column index.
+ * @return {@code true} if this column contains a null value, {@code false} otherwise.
+ */
+ boolean hasNullValue(int col);
+
Review Comment:
> schema-less copying of individual columns to other tuples (e.g. by SQL-engine when doing projections, etc);
> cheap calculation of hash value for a VARBINARY element, etc.
Both of these statements imply that data encoding algorithm is known and the same for every implementation, which is simply not true.
Plus, I would want to have `Object[]`-based implementation, for which it would be impossible to implement a method like this.
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/row/BinaryTuple.java:
##########
@@ -0,0 +1,223 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.schema.row;
+
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.time.Instant;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.util.BitSet;
+import java.util.UUID;
+import org.apache.ignite.internal.schema.InvalidTypeException;
+
+/**
+ * General interface to describe binary tuples outside of their data layout and column schemas.
+ * Accessor methods may or may not throw {@link InvalidTypeException} depending on the implementation.
+ */
+public interface BinaryTuple {
+ /**
+ * Returns a number of values in the tuple.
+ */
+ int count();
+
+ /**
+ * Checks whether the given column contains a null value.
+ *
+ * @param col Column index.
+ * @return {@code true} if this column contains a null value, {@code false} otherwise.
+ */
+ boolean hasNullValue(int col);
+
Review Comment:
> schema-less copying of individual columns to other tuples (e.g. by SQL-engine when doing projections, etc);
> cheap calculation of hash value for a VARBINARY element, etc.
Both of these statements imply that data encoding algorithm is known and is the same for every implementation, which is simply not true.
Plus, I would want to have `Object[]`-based implementation, for which it would be impossible to implement a method like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org