You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by "Claudenw (via GitHub)" <gi...@apache.org> on 2024/10/28 10:04:09 UTC
[PR] RAT-435: checkstyle fixes for root package [creadur-rat]
Claudenw opened a new pull request, #375:
URL: https://github.com/apache/creadur-rat/pull/375
fix for RAT-435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-435: checkstyle fixes for root package [creadur-rat]
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw commented on code in PR #375:
URL: https://github.com/apache/creadur-rat/pull/375#discussion_r1822648715
##########
apache-rat-core/src/main/java/org/apache/rat/BuilderParams.java:
##########
@@ -33,7 +33,7 @@ public interface BuilderParams {
/**
* Gets one of the contained methods by name.
- *
+ *
Review Comment:
I added comments to indicate the methods are called by reflection and also updated PR #366 (RAT-422) to test that the methods in the annotation exist in the BuilderParams class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-435: checkstyle fixes for root package [creadur-rat]
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw commented on code in PR #375:
URL: https://github.com/apache/creadur-rat/pull/375#discussion_r1823141200
##########
apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:
##########
@@ -279,15 +279,15 @@ public void addExcludedCollection(StandardCollection collection) {
* @param collection the StandardCollection to exclude.
* @see ExclusionProcessor#addFileProcessor(StandardCollection)
*/
- public void addExcludedFileProcessor(StandardCollection collection) {
+ public void addExcludedFileProcessor(final StandardCollection collection) {
Review Comment:
Handled in RAT-423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-435: checkstyle fixes for root package [creadur-rat]
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on code in PR #375:
URL: https://github.com/apache/creadur-rat/pull/375#discussion_r1821340971
##########
apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:
##########
@@ -279,15 +279,15 @@ public void addExcludedCollection(StandardCollection collection) {
* @param collection the StandardCollection to exclude.
* @see ExclusionProcessor#addFileProcessor(StandardCollection)
*/
- public void addExcludedFileProcessor(StandardCollection collection) {
+ public void addExcludedFileProcessor(final StandardCollection collection) {
Review Comment:
What to do with unused methods in here ..... (possibly referenced in other PRs) @Claudenw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-435: checkstyle fixes for root package [creadur-rat]
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on code in PR #375:
URL: https://github.com/apache/creadur-rat/pull/375#discussion_r1821333248
##########
apache-rat-core/src/main/java/org/apache/rat/BuilderParams.java:
##########
@@ -33,7 +33,7 @@ public interface BuilderParams {
/**
* Gets one of the contained methods by name.
- *
+ *
Review Comment:
matcherMap() and licenseFamilies() are reported as never used - is there a test case missing or is it called by reflection as well, @Claudenw ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-435: checkstyle fixes for root package [creadur-rat]
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw merged PR #375:
URL: https://github.com/apache/creadur-rat/pull/375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org