You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@druid.apache.org by GitBox <gi...@apache.org> on 2018/07/11 23:13:38 UTC

[GitHub] jon-wei closed pull request #5988: Coordinator fix exception caused by additional logging

jon-wei closed pull request #5988: Coordinator fix exception caused by additional logging
URL: https://github.com/apache/incubator-druid/pull/5988
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/src/main/java/io/druid/server/coordinator/CuratorLoadQueuePeon.java b/server/src/main/java/io/druid/server/coordinator/CuratorLoadQueuePeon.java
index d794b82cea5..aa831e7f043 100644
--- a/server/src/main/java/io/druid/server/coordinator/CuratorLoadQueuePeon.java
+++ b/server/src/main/java/io/druid/server/coordinator/CuratorLoadQueuePeon.java
@@ -386,13 +386,13 @@ private void entryRemoved(String path)
         );
         return;
       }
-      actionCompleted();
       log.info(
           "Server[%s] done processing %s of segment [%s]",
           basePath,
           currentlyProcessing.getType() == LOAD ? "load" : "drop",
           path
       );
+      actionCompleted();
     }
   }
 
diff --git a/server/src/main/java/io/druid/server/coordinator/rules/LoadRule.java b/server/src/main/java/io/druid/server/coordinator/rules/LoadRule.java
index 9dcee89bece..063063a92bd 100644
--- a/server/src/main/java/io/druid/server/coordinator/rules/LoadRule.java
+++ b/server/src/main/java/io/druid/server/coordinator/rules/LoadRule.java
@@ -247,7 +247,6 @@ private void assignReplicas(
           createLoadQueueSizeLimitingPredicate(params),
           segment
       );
-      log.info("Assigned %d replicas in tier [%s]", numAssigned, tier);
       stats.addToTieredStat(ASSIGNED_COUNT, tier, numAssigned);
     }
   }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
For additional commands, e-mail: dev-help@druid.apache.org