You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/29 15:30:39 UTC

[GitHub] [flink] zhijiangW edited a comment on pull request #12406: [FLINK-17994][checkpointing] Fix the race condition between CheckpointBarrierUnaligner#processBarrier and #notifyBarrierReceived

zhijiangW edited a comment on pull request #12406:
URL: https://github.com/apache/flink/pull/12406#issuecomment-636036676


   Thanks for the efficient review @pnowojski !
   
   >As far as I understand it, it's not a full fix, as EndOfPartitionEvents or checkpoint barrier cancellation markers can still cause the same race condition, and you want to fix it in a follow up PR, right? 
   
   Exactly, it only resolves partial race condition in this PR, and i also thought these still has some issues while handing EOF and cancellation marker, which seems hard to reproduce in `UnalignedCheckpointITCase`. Furthermore, considering the current logic inside `CheckpointBarrierUnaligner` is too complicated, actually it is totally different with my initial PoC version. I try to refactor some logics to simplify the process a bit while resolving the other two issues, so i choose to resolve them separately to not delay the whole progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org