You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/18 18:35:43 UTC
[GitHub] [airflow] daemon-demon opened a new pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
daemon-demon opened a new pull request #11019:
URL: https://github.com/apache/airflow/pull/11019
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
related: #6991
Allows the use of extra parameters while connecting to Postgres. The prior implementation only allowed passing ['sslmode', 'sslcert', 'sslkey','sslrootcert', 'sslcrl', 'application_name','keepalives_idle'] as extra parameters. With the new implementation, any parameter deemed extra can be passed without any restrictions.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#discussion_r493075189
##########
File path: airflow/providers/postgres/hooks/postgres.py
##########
@@ -89,15 +89,12 @@ def get_conn(self):
if raw_cursor:
conn_args['cursor_factory'] = self._get_cursor(raw_cursor)
# check for ssl parameters in conn.extra
+
for arg_name, arg_val in conn.extra_dejson.items():
- if arg_name in [
- 'sslmode',
- 'sslcert',
- 'sslkey',
- 'sslrootcert',
- 'sslcrl',
- 'application_name',
- 'keepalives_idle',
+ if arg_name not in [
+ 'iam',
+ 'redshift',
+ 'cursor',
Review comment:
I'm not that familiar with psycopg2 but why we exclude those extras?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#issuecomment-695170416
I think you need to rebase to latest master
That should fix the problem.i 've done some incompatible fixes few commits ago
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #11019:
URL: https://github.com/apache/airflow/pull/11019
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] daemon-demon commented on pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
daemon-demon commented on pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#issuecomment-700261960
> @daemon-demon I restarted all builds
I rebased my fork to the current master as per the direction and still, my build is getting cancelled. Could you let me know what I could do to resolve this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#issuecomment-695023316
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#discussion_r493075189
##########
File path: airflow/providers/postgres/hooks/postgres.py
##########
@@ -89,15 +89,12 @@ def get_conn(self):
if raw_cursor:
conn_args['cursor_factory'] = self._get_cursor(raw_cursor)
# check for ssl parameters in conn.extra
+
for arg_name, arg_val in conn.extra_dejson.items():
- if arg_name in [
- 'sslmode',
- 'sslcert',
- 'sslkey',
- 'sslrootcert',
- 'sslcrl',
- 'application_name',
- 'keepalives_idle',
+ if arg_name not in [
+ 'iam',
+ 'redshift',
+ 'cursor',
Review comment:
I'm not that familiar with psycopg2 but why we exclude those extras?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] daemon-demon commented on pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
daemon-demon commented on pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#issuecomment-696982425
@potiuk Even after rebasing, I was not able to start the checks again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] daemon-demon commented on pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
daemon-demon commented on pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#issuecomment-696982425
@potiuk Even after rebasing, I was not able to start the checks again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#issuecomment-697021213
@daemon-demon I restarted all builds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#discussion_r507650623
##########
File path: airflow/providers/postgres/hooks/postgres.py
##########
@@ -97,15 +97,12 @@ def get_conn(self) -> connection:
if raw_cursor:
conn_args['cursor_factory'] = self._get_cursor(raw_cursor)
# check for ssl parameters in conn.extra
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#issuecomment-712189454
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#issuecomment-700592444
@daemon-demon -> I think you have not finally rebased it - you will need need to force-push your changes. I have not set any force push coming in the PR, so you likely simply did not push it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] daemon-demon commented on a change in pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
daemon-demon commented on a change in pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#discussion_r495223805
##########
File path: airflow/providers/postgres/hooks/postgres.py
##########
@@ -89,15 +89,12 @@ def get_conn(self):
if raw_cursor:
conn_args['cursor_factory'] = self._get_cursor(raw_cursor)
# check for ssl parameters in conn.extra
+
for arg_name, arg_val in conn.extra_dejson.items():
- if arg_name in [
- 'sslmode',
- 'sslcert',
- 'sslkey',
- 'sslrootcert',
- 'sslcrl',
- 'application_name',
- 'keepalives_idle',
+ if arg_name not in [
+ 'iam',
+ 'redshift',
+ 'cursor',
Review comment:
These extras have already been handled elsewhere in the code and do not go as parameters to psycopg2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11019: [Airflow-10505] Change to pass all extra connection paramaters to psycopg2
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#issuecomment-697021213
@daemon-demon I restarted all builds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org