You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Yukang-Lian (via GitHub)" <gi...@apache.org> on 2024/02/26 03:24:26 UTC
[PR] [Enhancement](group commit) optimize some group commit code [doris]
Yukang-Lian opened a new pull request, #31392:
URL: https://github.com/apache/doris/pull/31392
This PR optimizes some of the logic related to group commit:
1. Improved the error handling when there is insufficient WAL space during import.
2. Accounted for cases where the content length is negative during import.
3. Added missing error log printing in `group_commit_mgr.cpp`.
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1964205433
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963641344
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit e23c79b80cfaa1853b5b379ca870250b1ebfc3f7 with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 15.5 seconds inserted 10000000 Rows, about 645K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1964185898
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963252025
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963272413
<details>
<summary>TPC-H: <b>Total hot run time: 40943 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a688bec3af1a3d778bbf222f8d6ddb43e4ba1a61, data reload: false
------ Round 1 ----------------------------------
q1 17682 5000 4870 4870
q2 2040 140 134 134
q3 10585 996 995 995
q4 4663 972 965 965
q5 7616 3198 3190 3190
q6 195 135 134 134
q7 1267 773 760 760
q8 9291 2057 2050 2050
q9 7444 6543 6581 6543
q10 8328 2638 2632 2632
q11 419 218 205 205
q12 722 334 327 327
q13 17927 3625 3596 3596
q14 301 257 265 257
q15 582 535 503 503
q16 479 403 416 403
q17 917 880 851 851
q18 7408 6585 6531 6531
q19 1542 1505 1489 1489
q20 556 284 274 274
q21 6332 3907 3986 3907
q22 889 350 327 327
Total cold run time: 107185 ms
Total hot run time: 40943 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4855 4852 4858 4852
q2 294 180 188 180
q3 3613 3577 3593 3577
q4 2547 2559 2577 2559
q5 5748 5751 5750 5750
q6 210 130 132 130
q7 2250 1705 1635 1635
q8 3032 3098 3091 3091
q9 8746 8686 8715 8686
q10 6790 4240 4251 4240
q11 522 391 379 379
q12 784 548 561 548
q13 4755 3410 3410 3410
q14 269 247 230 230
q15 637 545 552 545
q16 499 463 442 442
q17 1681 1612 1625 1612
q18 8250 7661 7621 7621
q19 1630 1639 1636 1636
q20 2102 1846 1836 1836
q21 6645 6276 6253 6253
q22 577 494 538 494
Total cold run time: 66436 ms
Total hot run time: 59706 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963625921
<details>
<summary>TPC-DS: <b>Total hot run time: 176253 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e23c79b80cfaa1853b5b379ca870250b1ebfc3f7, data reload: false
query1 926 350 341 341
query2 6535 1767 1821 1767
query3 6696 204 201 201
query4 22980 21154 21060 21060
query5 4187 371 370 370
query6 276 164 162 162
query7 4619 296 294 294
query8 243 188 206 188
query9 8490 2785 2780 2780
query10 414 220 233 220
query11 14976 14446 14403 14403
query12 137 85 80 80
query13 1693 412 424 412
query14 9088 7501 7544 7501
query15 205 187 188 187
query16 7487 264 252 252
query17 1402 545 528 528
query18 1946 257 258 257
query19 191 145 144 144
query20 85 82 84 82
query21 182 126 125 125
query22 4999 4731 4737 4731
query23 32354 31447 31516 31447
query24 12721 3423 3443 3423
query25 638 366 351 351
query26 1868 153 155 153
query27 3056 311 322 311
query28 6646 1806 1785 1785
query29 1142 606 602 602
query30 278 139 142 139
query31 909 745 760 745
query32 99 58 55 55
query33 717 233 259 233
query34 1048 471 491 471
query35 907 797 800 797
query36 970 943 872 872
query37 169 60 57 57
query38 3329 3251 3238 3238
query39 1352 1322 1328 1322
query40 284 103 105 103
query41 37 35 35 35
query42 104 99 99 99
query43 483 447 448 447
query44 1082 688 698 688
query45 190 194 176 176
query46 1048 774 741 741
query47 1643 1548 1604 1548
query48 410 347 337 337
query49 1210 304 304 304
query50 774 375 362 362
query51 4367 4333 4322 4322
query52 95 91 95 91
query53 390 301 296 296
query54 293 220 219 219
query55 90 79 75 75
query56 218 201 202 201
query57 1063 937 989 937
query58 217 195 200 195
query59 2473 2320 2399 2320
query60 246 212 213 212
query61 85 83 89 83
query62 597 381 362 362
query63 325 284 284 284
query64 6403 3088 3109 3088
query65 3287 3239 3243 3239
query66 1332 326 316 316
query67 14745 14433 14100 14100
query68 5139 522 534 522
query69 486 352 350 350
query70 1246 1260 1194 1194
query71 374 252 252 252
query72 6424 2749 2598 2598
query73 710 315 306 306
query74 6867 6459 6462 6459
query75 3161 2541 2565 2541
query76 3240 1158 1190 1158
query77 352 238 229 229
query78 9365 8756 8783 8756
query79 1050 498 518 498
query80 698 351 337 337
query81 443 209 206 206
query82 1280 87 85 85
query83 234 121 119 119
query84 223 77 76 76
query85 1200 344 343 343
query86 303 301 305 301
query87 3475 3294 3273 3273
query88 2676 2281 2283 2281
query89 430 357 358 357
query90 2143 164 160 160
query91 152 132 126 126
query92 51 51 49 49
query93 1020 511 486 486
query94 1193 176 173 173
query95 426 336 344 336
query96 560 262 265 262
query97 4424 4285 4237 4237
query98 239 203 201 201
query99 1126 734 716 716
Total cold run time: 270161 ms
Total hot run time: 176253 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963606274
<details>
<summary>TPC-H: <b>Total hot run time: 40892 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e23c79b80cfaa1853b5b379ca870250b1ebfc3f7, data reload: false
------ Round 1 ----------------------------------
q1 17628 4968 4839 4839
q2 2037 142 136 136
q3 10583 998 1005 998
q4 4654 950 959 950
q5 7624 3131 3182 3131
q6 190 132 132 132
q7 1254 771 753 753
q8 9224 2051 2038 2038
q9 7469 6571 6563 6563
q10 8295 2627 2629 2627
q11 412 219 207 207
q12 778 329 334 329
q13 17926 3613 3594 3594
q14 293 268 252 252
q15 618 507 518 507
q16 466 424 443 424
q17 921 872 878 872
q18 7483 6557 6657 6557
q19 1532 1480 1472 1472
q20 551 270 268 268
q21 6774 3910 3967 3910
q22 875 337 333 333
Total cold run time: 107587 ms
Total hot run time: 40892 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4834 4814 4801 4801
q2 286 178 187 178
q3 3577 3562 3555 3555
q4 2489 2487 2504 2487
q5 5719 5720 5719 5719
q6 209 120 125 120
q7 2241 1644 1643 1643
q8 3001 3094 3097 3094
q9 8666 8660 8704 8660
q10 6751 4217 4222 4217
q11 502 382 386 382
q12 763 543 543 543
q13 5377 3379 3391 3379
q14 270 239 241 239
q15 643 508 501 501
q16 464 417 438 417
q17 1614 1590 1590 1590
q18 8195 7663 7558 7558
q19 1633 1637 1627 1627
q20 2096 1819 1825 1819
q21 6495 6135 6117 6117
q22 567 497 521 497
Total cold run time: 66392 ms
Total hot run time: 59143 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963481214
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963286081
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit a688bec3af1a3d778bbf222f8d6ddb43e4ba1a61 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select: 15.5 seconds inserted 10000000 Rows, about 645K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963283890
<details>
<summary>ClickBench: <b>Total hot run time: 31.3 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a688bec3af1a3d778bbf222f8d6ddb43e4ba1a61, data reload: false
query1 0.03 0.02 0.02
query2 0.07 0.03 0.03
query3 0.23 0.08 0.07
query4 1.62 0.09 0.09
query5 0.49 0.48 0.49
query6 1.35 0.61 0.62
query7 0.02 0.01 0.02
query8 0.03 0.02 0.03
query9 0.53 0.46 0.45
query10 0.51 0.49 0.49
query11 0.13 0.09 0.10
query12 0.12 0.11 0.10
query13 0.59 0.58 0.58
query14 0.76 0.79 0.79
query15 0.81 0.80 0.80
query16 0.34 0.34 0.33
query17 0.93 0.92 0.90
query18 0.18 0.16 0.18
query19 1.83 1.71 1.71
query20 0.01 0.01 0.01
query21 15.42 0.63 0.60
query22 3.29 3.83 2.62
query23 17.59 1.10 1.17
query24 2.16 0.61 0.24
query25 0.58 0.07 0.06
query26 0.16 0.14 0.14
query27 0.06 0.05 0.06
query28 11.89 0.84 0.85
query29 12.63 3.38 3.30
query30 0.57 0.47 0.49
query31 2.78 0.36 0.36
query32 3.32 0.47 0.48
query33 3.17 3.14 3.18
query34 15.36 4.51 4.48
query35 4.52 4.50 4.48
query36 1.07 0.96 0.94
query37 0.07 0.05 0.05
query38 0.04 0.02 0.03
query39 0.02 0.02 0.01
query40 0.18 0.15 0.15
query41 0.07 0.02 0.01
query42 0.03 0.01 0.01
query43 0.02 0.02 0.02
Total cold run time: 105.58 s
Total hot run time: 31.3 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1964221566
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963425288
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963279851
<details>
<summary>TPC-DS: <b>Total hot run time: 177230 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a688bec3af1a3d778bbf222f8d6ddb43e4ba1a61, data reload: false
query1 951 347 349 347
query2 6514 1818 1750 1750
query3 6690 210 203 203
query4 23073 21202 21235 21202
query5 4276 372 378 372
query6 255 171 172 171
query7 4607 311 291 291
query8 256 196 204 196
query9 8446 2867 2866 2866
query10 427 231 245 231
query11 14987 14506 14492 14492
query12 143 89 85 85
query13 1718 424 431 424
query14 9254 7772 7721 7721
query15 212 194 194 194
query16 7612 249 252 249
query17 1405 536 518 518
query18 1943 263 260 260
query19 185 153 145 145
query20 87 81 84 81
query21 187 120 116 116
query22 4920 4782 4598 4598
query23 32447 31542 31645 31542
query24 12725 3370 3434 3370
query25 651 372 364 364
query26 1869 154 160 154
query27 3060 321 317 317
query28 6568 1822 1804 1804
query29 1118 612 608 608
query30 280 136 147 136
query31 926 743 759 743
query32 98 60 56 56
query33 717 235 231 231
query34 1067 500 501 500
query35 952 830 840 830
query36 954 920 909 909
query37 168 61 62 61
query38 3309 3174 3145 3145
query39 1394 1344 1329 1329
query40 287 106 102 102
query41 36 36 36 36
query42 108 100 96 96
query43 494 473 454 454
query44 1060 691 713 691
query45 192 181 178 178
query46 1035 772 766 766
query47 1672 1582 1573 1573
query48 411 347 344 344
query49 1244 314 306 306
query50 769 376 374 374
query51 4502 4380 4317 4317
query52 103 89 95 89
query53 421 305 297 297
query54 293 211 227 211
query55 86 82 76 76
query56 220 196 202 196
query57 1056 936 948 936
query58 223 195 192 192
query59 2428 2424 2261 2261
query60 241 226 217 217
query61 83 81 79 79
query62 592 388 368 368
query63 327 291 291 291
query64 6171 3097 3133 3097
query65 3294 3251 3241 3241
query66 1337 332 319 319
query67 14289 14415 14501 14415
query68 5094 582 548 548
query69 537 368 351 351
query70 1315 1224 1227 1224
query71 434 250 245 245
query72 6411 2777 2622 2622
query73 691 321 312 312
query74 6802 6418 6456 6418
query75 3263 2571 2554 2554
query76 3381 1137 1214 1137
query77 355 236 230 230
query78 9435 8877 8724 8724
query79 958 496 512 496
query80 518 364 335 335
query81 440 201 206 201
query82 242 93 84 84
query83 145 123 122 122
query84 223 81 81 81
query85 1022 353 351 351
query86 296 307 305 305
query87 3435 3324 3269 3269
query88 2724 2304 2303 2303
query89 436 354 360 354
query90 1929 167 170 167
query91 167 131 128 128
query92 57 54 50 50
query93 1002 520 493 493
query94 1132 187 180 180
query95 442 336 349 336
query96 570 268 265 265
query97 4454 4296 4293 4293
query98 220 202 198 198
query99 1047 770 721 721
Total cold run time: 268602 ms
Total hot run time: 177230 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963551999
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963259303
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963309313
TeamCity be ut coverage result:
Function Coverage: 35.72% (8546/23923)
Line Coverage: 27.52% (69341/251957)
Region Coverage: 26.67% (35959/134833)
Branch Coverage: 23.48% (18381/78300)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a688bec3af1a3d778bbf222f8d6ddb43e4ba1a61_a688bec3af1a3d778bbf222f8d6ddb43e4ba1a61/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963478805
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963635813
<details>
<summary>ClickBench: <b>Total hot run time: 30.65 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e23c79b80cfaa1853b5b379ca870250b1ebfc3f7, data reload: false
query1 0.03 0.02 0.02
query2 0.06 0.03 0.02
query3 0.23 0.08 0.08
query4 1.64 0.08 0.09
query5 0.49 0.49 0.47
query6 1.37 0.61 0.62
query7 0.02 0.01 0.01
query8 0.04 0.03 0.02
query9 0.51 0.46 0.46
query10 0.49 0.49 0.49
query11 0.12 0.09 0.09
query12 0.12 0.10 0.09
query13 0.59 0.59 0.58
query14 0.76 0.80 0.78
query15 0.80 0.80 0.78
query16 0.32 0.33 0.34
query17 0.93 0.91 0.91
query18 0.19 0.18 0.18
query19 1.76 1.70 1.69
query20 0.02 0.01 0.01
query21 15.44 0.65 0.58
query22 2.79 4.10 2.25
query23 17.51 1.06 0.94
query24 1.96 0.23 0.76
query25 0.63 0.06 0.05
query26 0.15 0.14 0.13
query27 0.06 0.05 0.05
query28 12.08 0.83 0.82
query29 12.52 3.41 3.29
query30 0.51 0.47 0.48
query31 2.78 0.36 0.35
query32 3.36 0.48 0.47
query33 3.12 3.14 3.13
query34 15.35 4.50 4.49
query35 4.55 4.50 4.52
query36 1.07 0.93 0.95
query37 0.07 0.05 0.06
query38 0.04 0.03 0.03
query39 0.02 0.02 0.01
query40 0.17 0.15 0.14
query41 0.08 0.01 0.02
query42 0.02 0.02 0.01
query43 0.03 0.02 0.02
Total cold run time: 104.8 s
Total hot run time: 30.65 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963478855
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1964276502
TeamCity be ut coverage result:
Function Coverage: 35.71% (8547/23934)
Line Coverage: 27.52% (69379/252104)
Region Coverage: 26.67% (35968/134885)
Branch Coverage: 23.47% (18386/78324)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9ec048f9e51b57e4976f8c125763bee33a67ce18_9ec048f9e51b57e4976f8c125763bee33a67ce18/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963590968
TeamCity be ut coverage result:
Function Coverage: 35.73% (8548/23923)
Line Coverage: 27.53% (69356/251957)
Region Coverage: 26.68% (35967/134833)
Branch Coverage: 23.48% (18383/78300)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e23c79b80cfaa1853b5b379ca870250b1ebfc3f7_e23c79b80cfaa1853b5b379ca870250b1ebfc3f7/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "zhannngchen (via GitHub)" <gi...@apache.org>.
zhannngchen merged PR #31392:
URL: https://github.com/apache/doris/pull/31392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963698560
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1964199265
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963252138
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1963566462
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](group commit) optimize some group commit code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31392:
URL: https://github.com/apache/doris/pull/31392#issuecomment-1965972751
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org