You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by kiszk <gi...@git.apache.org> on 2018/09/07 09:25:03 UTC

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21221#discussion_r215899049
  
    --- Diff: core/src/main/java/org/apache/spark/SparkFirehoseListener.java ---
    @@ -103,6 +103,12 @@ public final void onExecutorMetricsUpdate(
         onEvent(executorMetricsUpdate);
       }
     
    +  @Override
    +  public final void onStageExecutorMetrics(
    +          SparkListenerStageExecutorMetrics executorMetrics) {
    --- End diff --
    
    nit: remove extra spaces for better indent


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org