You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (Jira)" <ji...@apache.org> on 2020/04/22 05:57:00 UTC
[jira] [Commented] (HIVE-23236) Remove the global lock from
acquireLock
[ https://issues.apache.org/jira/browse/HIVE-23236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089309#comment-17089309 ]
Hive QA commented on HIVE-23236:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 25s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 22s{color} | {color:blue} standalone-metastore/metastore-server in master has 190 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 23s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 6 new + 518 unchanged - 4 fixed = 524 total (was 522) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 4 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 27s{color} | {color:red} standalone-metastore/metastore-server generated 2 new + 190 unchanged - 0 fixed = 192 total (was 190) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 15s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 17s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
| | org.apache.hadoop.hive.metastore.txn.TxnHandler.lockComponentsForUpdate(Connection, long) may fail to clean up java.sql.ResultSet Obligation to clean up resource created at TxnHandler.java:clean up java.sql.ResultSet Obligation to clean up resource created at TxnHandler.java:[line 4443] is not discharged |
| | org.apache.hadoop.hive.metastore.txn.TxnHandler.lockComponentsForUpdate(Connection, long) passes a nonconstant String to an execute or addBatch method on an SQL statement At TxnHandler.java:String to an execute or addBatch method on an SQL statement At TxnHandler.java:[line 4443] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21842/dev-support/hive-personality.sh |
| git revision | master / 8b9fadb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21842/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt |
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-21842/yetus/whitespace-tabs.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-21842/yetus/new-findbugs-standalone-metastore_metastore-server.html |
| asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-21842/yetus/patch-asflicense-problems.txt |
| modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21842/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Remove the global lock from acquireLock
> ---------------------------------------
>
> Key: HIVE-23236
> URL: https://issues.apache.org/jira/browse/HIVE-23236
> Project: Hive
> Issue Type: Improvement
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Attachments: HIVE-23236.1.patch, HIVE-23236.2.patch
>
>
> Currently we have a global lock (NEXT_LOCK_ID) when running enqueueLock, because the algorithm in checkLock requires the locks to have a well defined order, and also requires that every lock component is already stored in the RDBMS before checking the locks.
> Proposed approach:
> * Enqueue locks without a global S4U lock, using an auto-incremented value instead to get the next lock ID (modify next_lock_id table)
> * Before checking for lock conflicts, issue a S4U for all lock components we are requesting (db/table/partition level) in order to prevent other clients for doing interleaving conflict check (especially late-coming clients holding a lower lockID)
> * Conflict check algorithm to check not just for lower lockIDs, but also higher lockIDs which are already in 'acquired' state
--
This message was sent by Atlassian Jira
(v8.3.4#803005)