[GitHub] johnament commented on a change in pull request #373: JAX-RS 2.1 TCK issues

[GitBox <gi...@apache.org>]

johnament commented on a change in pull request #373: JAX-RS 2.1 TCK issues
URL: https://github.com/apache/cxf/pull/373#discussion_r165429936
 
 

 ##########
 File path: rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/spec/InvocationBuilderImpl.java
 ##########
 @@ -253,10 +253,13 @@ public Builder header(String name, Object value) {
 
     @Override
     public Builder headers(MultivaluedMap<String, Object> headers) {
-        RuntimeDelegate rd = HttpUtils.getOtherRuntimeDelegate();
-        for (Map.Entry<String, List<Object>> entry : headers.entrySet()) {
-            for (Object value : entry.getValue()) {
-                doSetHeader(rd, entry.getKey(), value);
+        webClient.removeAllHeaders();
+        if (headers != null) {
 
 Review comment:
   does the TCK check that `.headers(null)` should clear all headers?  Seems odd to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services