You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/06 10:46:17 UTC
[GitHub] [arrow] kszucs opened a new pull request #7113: [CI] Fix archery option in pandas master cron test
kszucs opened a new pull request #7113:
URL: https://github.com/apache/arrow/pull/7113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #7113: [CI] Fix archery option in pandas master cron test
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #7113:
URL: https://github.com/apache/arrow/pull/7113#issuecomment-625185090
The failure in pandas master is covered in https://issues.apache.org/jira/browse/ARROW-8643. It's an easy fix, but I am discussion on the pandas side whether the change shouldn't be reverted there (now, until that discussion is settled, it's maybe easier to fix the test here anyway, to avoid the failure. Will do a quick PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7113: ARROW-8740: [CI] Fix archery option in pandas master cron test
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7113:
URL: https://github.com/apache/arrow/pull/7113#issuecomment-625817459
https://issues.apache.org/jira/browse/ARROW-8740
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche edited a comment on pull request #7113: [CI] Fix archery option in pandas master cron test
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche edited a comment on pull request #7113:
URL: https://github.com/apache/arrow/pull/7113#issuecomment-625185090
The failure in pandas master is covered in https://issues.apache.org/jira/browse/ARROW-8643. It's an easy fix, but I am discussing on the pandas side whether the change shouldn't be reverted there (now, until that discussion is settled, it's maybe easier to fix the test here anyway, to avoid the failure. Will do a quick PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #7113: [CI] Fix archery option in pandas master cron test
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #7113:
URL: https://github.com/apache/arrow/pull/7113#issuecomment-625188271
-> https://github.com/apache/arrow/pull/7124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7113: [MINOR][CI] Fix archery option in pandas master cron test
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7113:
URL: https://github.com/apache/arrow/pull/7113#issuecomment-624697127
Hm, there was a test failure
```
____________ TestConvertMetadata.test_table_column_subset_metadata _____________
self = <pyarrow.tests.test_pandas.TestConvertMetadata object at 0x7f759a900960>
def test_table_column_subset_metadata(self):
# ARROW-1883
# non-default index
for index in [
pd.Index(['a', 'b', 'c'], name='index'),
pd.date_range("2017-01-01", periods=3, tz='Europe/Brussels')]:
df = pd.DataFrame({'a': [1, 2, 3],
'b': [.1, .2, .3]}, index=index)
table = pa.Table.from_pandas(df)
table_subset = table.remove_column(1)
result = table_subset.to_pandas()
> tm.assert_frame_equal(result, df[['a']])
E AssertionError: (None, <Day>)
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/test_pandas.py:506: AssertionError
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7113: [CI] Fix archery option in pandas master cron test
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7113:
URL: https://github.com/apache/arrow/pull/7113#issuecomment-624575887
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org