You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Dong Li (JIRA)" <ji...@apache.org> on 2017/12/17 09:25:00 UTC
[jira] [Resolved] (KYLIN-3111) Close of Admin instance should be
placed in finally block
[ https://issues.apache.org/jira/browse/KYLIN-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dong Li resolved KYLIN-3111.
----------------------------
Resolution: Fixed
Fix Version/s: v2.3.0
Merged to master branch, thanks Chao!
> Close of Admin instance should be placed in finally block
> ---------------------------------------------------------
>
> Key: KYLIN-3111
> URL: https://issues.apache.org/jira/browse/KYLIN-3111
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Chao Long
> Fix For: v2.3.0
>
> Attachments: KYLIN-3111-Place-close-of-admin-instance-into-finally-block.patch
>
>
> Looking at the code in DeployCoprocessorCLI.java and HtableAlterMetadataCLI.java , I see that close of Admin instance is without finally block:
> {code}
> hbaseAdmin.disableTable(table.getTableName());
> table.setValue(metadataKey, metadataValue);
> hbaseAdmin.modifyTable(table.getTableName(), table);
> hbaseAdmin.enableTable(table.getTableName());
> hbaseAdmin.close();
> {code}
> If any exception is thrown in the operations prior to the close(), the close() would be skipped, leading to resource leak.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)