You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "nicktelford (via GitHub)" <gi...@apache.org> on 2026/05/18 16:56:00 UTC

[PR] KAFKA-20497: Add readOnly(IsolationLevel) to CachingKeyValueStore [kafka]

nicktelford opened a new pull request, #22312:
URL: https://github.com/apache/kafka/pull/22312

   The cache holds uncommitted writes that must not be visible under
   READ_COMMITTED, so that isolation level bypasses the cache entirely and
   delegates straight to the inner store's readOnly view. READ_UNCOMMITTED
   requires a merged view of both cache and store, so a ReadOnlyView inner
   class is introduced that reuses the rangeInternal/allInternal/
   prefixScanInternal helpers extracted from the public methods.
   
   getInternal is refactored to accept an explicit underlying store so that
   the ReadOnlyView can share the same cache-merge logic without duplicating
   the MergedSortedCache wiring, keeping the view consistent with the
   store's own point-lookup semantics as the implementation evolves. The
   null-check, store-open guard, and locking are consolidated into
   getInternal itself so that both the public get() and the ReadOnlyView's
   get() share the same precondition and synchronisation behaviour.
   
   KAFKA-20497


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20497: Add readOnly(IsolationLevel) to CachingKeyValueStore [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22312:
URL: https://github.com/apache/kafka/pull/22312#issuecomment-4540047476

   A label of 'needs-attention' was automatically added to this PR in order to raise the
   attention of the committers. Once this issue has been triaged, the `triage` label
   should be removed to prevent this automation from happening again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20497: Add readOnly(IsolationLevel) to CachingKeyValueStore [kafka]

Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on PR #22312:
URL: https://github.com/apache/kafka/pull/22312#issuecomment-4612558282

   merged #22312 into trunk


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20497: Add readOnly(IsolationLevel) to CachingKeyValueStore [kafka]

Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck merged PR #22312:
URL: https://github.com/apache/kafka/pull/22312


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20497: Add readOnly(IsolationLevel) to CachingKeyValueStore [kafka]

Posted by "nicktelford (via GitHub)" <gi...@apache.org>.
nicktelford commented on PR #22312:
URL: https://github.com/apache/kafka/pull/22312#issuecomment-4479919727

   @bbejeck


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20497: Add readOnly(IsolationLevel) to CachingKeyValueStore [kafka]

Posted by "nicktelford (via GitHub)" <gi...@apache.org>.
nicktelford commented on code in PR #22312:
URL: https://github.com/apache/kafka/pull/22312#discussion_r3341552777


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java:
##########


Review Comment:
   Rebased on trunk: this should now be resolved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20497: Add readOnly(IsolationLevel) to CachingKeyValueStore [kafka]

Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on code in PR #22312:
URL: https://github.com/apache/kafka/pull/22312#discussion_r3336614868


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java:
##########


Review Comment:
   This needs to be updated to the new API, it's not compiling otherwise



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org