You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/24 15:45:24 UTC

[GitHub] [flink] pnowojski opened a new pull request #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

pnowojski opened a new pull request #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943
 
 
   If the StreamTask is being cancelled, let the Task handle the exception.
   
   ## Verifying this change
   
   This change is already covered by existing tests, like end to end tests checking logs for unexpected exceptions.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#issuecomment-578186145
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c83bca0f185f04f6ed81301ab1c609e3ec347b71 (Fri Jan 24 15:49:19 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#issuecomment-578198896
 
 
   <!--
   Meta data
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145963713 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:419ada6f10c5e7a53346aa979c7bdb1afd000418 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4623 TriggerType:PUSH TriggerID:419ada6f10c5e7a53346aa979c7bdb1afd000418
   Hash:419ada6f10c5e7a53346aa979c7bdb1afd000418 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146181825 TriggerType:PUSH TriggerID:419ada6f10c5e7a53346aa979c7bdb1afd000418
   Hash:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4626 TriggerType:PUSH TriggerID:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc
   Hash:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146196693 TriggerType:PUSH TriggerID:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc
   -->
   ## CI report:
   
   * c83bca0f185f04f6ed81301ab1c609e3ec347b71 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145963713) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611) 
   * 419ada6f10c5e7a53346aa979c7bdb1afd000418 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146181825) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4623) 
   * 9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146196693) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4626) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#issuecomment-578198896
 
 
   <!--
   Meta data
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145963713 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:419ada6f10c5e7a53346aa979c7bdb1afd000418 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4623 TriggerType:PUSH TriggerID:419ada6f10c5e7a53346aa979c7bdb1afd000418
   Hash:419ada6f10c5e7a53346aa979c7bdb1afd000418 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146181825 TriggerType:PUSH TriggerID:419ada6f10c5e7a53346aa979c7bdb1afd000418
   Hash:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc
   -->
   ## CI report:
   
   * c83bca0f185f04f6ed81301ab1c609e3ec347b71 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145963713) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611) 
   * 419ada6f10c5e7a53346aa979c7bdb1afd000418 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146181825) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4623) 
   * 9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#issuecomment-578198896
 
 
   <!--
   Meta data
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145963713 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   -->
   ## CI report:
   
   * c83bca0f185f04f6ed81301ab1c609e3ec347b71 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145963713) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#issuecomment-578198896
 
 
   <!--
   Meta data
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145963713 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:419ada6f10c5e7a53346aa979c7bdb1afd000418 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4623 TriggerType:PUSH TriggerID:419ada6f10c5e7a53346aa979c7bdb1afd000418
   Hash:419ada6f10c5e7a53346aa979c7bdb1afd000418 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146181825 TriggerType:PUSH TriggerID:419ada6f10c5e7a53346aa979c7bdb1afd000418
   Hash:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4626 TriggerType:PUSH TriggerID:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc
   Hash:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146196693 TriggerType:PUSH TriggerID:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc
   -->
   ## CI report:
   
   * c83bca0f185f04f6ed81301ab1c609e3ec347b71 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145963713) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611) 
   * 419ada6f10c5e7a53346aa979c7bdb1afd000418 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146181825) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4623) 
   * 9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146196693) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4626) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#discussion_r371126747
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -493,8 +493,6 @@ private void runMailboxLoop() throws Exception {
 					Thread.currentThread().interrupt();
 					throw interruption.get();
 				}
-			} else if (canceled) {
-				LOG.warn("Error while canceling task.", e);
 
 Review comment:
   Could it be? There is still need for 3 different branches. Admittedly branches could be re-order to avoid one level of nesting, but still, how could they be squashed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#issuecomment-578198896
 
 
   <!--
   Meta data
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145963713 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   -->
   ## CI report:
   
   * c83bca0f185f04f6ed81301ab1c609e3ec347b71 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145963713) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#issuecomment-578198896
 
 
   <!--
   Meta data
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145963713 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:419ada6f10c5e7a53346aa979c7bdb1afd000418 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4623 TriggerType:PUSH TriggerID:419ada6f10c5e7a53346aa979c7bdb1afd000418
   Hash:419ada6f10c5e7a53346aa979c7bdb1afd000418 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146181825 TriggerType:PUSH TriggerID:419ada6f10c5e7a53346aa979c7bdb1afd000418
   -->
   ## CI report:
   
   * c83bca0f185f04f6ed81301ab1c609e3ec347b71 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145963713) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611) 
   * 419ada6f10c5e7a53346aa979c7bdb1afd000418 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146181825) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4623) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#issuecomment-578198896
 
 
   <!--
   Meta data
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145963713 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:419ada6f10c5e7a53346aa979c7bdb1afd000418 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4623 TriggerType:PUSH TriggerID:419ada6f10c5e7a53346aa979c7bdb1afd000418
   Hash:419ada6f10c5e7a53346aa979c7bdb1afd000418 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146181825 TriggerType:PUSH TriggerID:419ada6f10c5e7a53346aa979c7bdb1afd000418
   Hash:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4626 TriggerType:PUSH TriggerID:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc
   Hash:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146196693 TriggerType:PUSH TriggerID:9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc
   -->
   ## CI report:
   
   * c83bca0f185f04f6ed81301ab1c609e3ec347b71 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145963713) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611) 
   * 419ada6f10c5e7a53346aa979c7bdb1afd000418 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146181825) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4623) 
   * 9d91ac73596ebea13bedbfbc36a6d7f37e69d5dc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146196693) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4626) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#issuecomment-578198896
 
 
   <!--
   Meta data
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145963713 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:419ada6f10c5e7a53346aa979c7bdb1afd000418 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4623 TriggerType:PUSH TriggerID:419ada6f10c5e7a53346aa979c7bdb1afd000418
   Hash:419ada6f10c5e7a53346aa979c7bdb1afd000418 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146181825 TriggerType:PUSH TriggerID:419ada6f10c5e7a53346aa979c7bdb1afd000418
   -->
   ## CI report:
   
   * c83bca0f185f04f6ed81301ab1c609e3ec347b71 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145963713) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611) 
   * 419ada6f10c5e7a53346aa979c7bdb1afd000418 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146181825) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4623) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#issuecomment-578198896
 
 
   <!--
   Meta data
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   -->
   ## CI report:
   
   * c83bca0f185f04f6ed81301ab1c609e3ec347b71 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rkhachatryan commented on a change in pull request #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#discussion_r370720552
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -493,8 +493,6 @@ private void runMailboxLoop() throws Exception {
 					Thread.currentThread().interrupt();
 					throw interruption.get();
 				}
-			} else if (canceled) {
-				LOG.warn("Error while canceling task.", e);
 
 Review comment:
   nit: condition can now be simplified to `interruption.isPresent() && !canceled`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943#issuecomment-578198896
 
 
   <!--
   Meta data
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145963713 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:c83bca0f185f04f6ed81301ab1c609e3ec347b71 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611 TriggerType:PUSH TriggerID:c83bca0f185f04f6ed81301ab1c609e3ec347b71
   Hash:419ada6f10c5e7a53346aa979c7bdb1afd000418 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:419ada6f10c5e7a53346aa979c7bdb1afd000418
   -->
   ## CI report:
   
   * c83bca0f185f04f6ed81301ab1c609e3ec347b71 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145963713) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4611) 
   * 419ada6f10c5e7a53346aa979c7bdb1afd000418 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski merged pull request #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop

Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #10943: [FLINK-15751][task] Let all exceptions propagate from the StreamTask#runMailboxLoop
URL: https://github.com/apache/flink/pull/10943
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services