[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #751: HDDS-3321. Prometheus endpoint should not have Authentication filter …

[GitBox <gi...@apache.org>]

avijayanhwx commented on a change in pull request #751: HDDS-3321. Prometheus endpoint should not have Authentication filter …
URL: https://github.com/apache/hadoop-ozone/pull/751#discussion_r402550880
 
 

 ##########
 File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/BaseHttpServer.java
 ##########
 @@ -116,7 +120,15 @@ public BaseHttpServer(Configuration conf, String name) throws IOException {
         prometheusMetricsSink = new PrometheusMetricsSink();
         httpServer.getWebAppContext().getServletContext()
             .setAttribute(PROMETHEUS_SINK, prometheusMetricsSink);
-        httpServer.addInternalServlet("prometheus", "/prom", PrometheusServlet.class);
+        HddsPrometheusConfig prometheusConfig =
+            ((OzoneConfiguration)conf).getObject(HddsPrometheusConfig.class);
+        if (!prometheusConfig.isSpnegoAuthEnabled()) {
 
 Review comment:
   Thanks! Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org