You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/06/29 19:33:48 UTC

[PR] [SPARK-57755][INFRA] Replace deprecated `apt-key` with `/etc/apt/trusted.gpg.d` keyring file [spark]

dongjoon-hyun opened a new pull request, #56868:
URL: https://github.com/apache/spark/pull/56868

   ### What changes were proposed in this pull request?
   
   This PR replaces the deprecated `apt-key add` with a keyring file under
   `/etc/apt/trusted.gpg.d/` in three dev Dockerfiles
   (`dev/create-release/spark-rm/Dockerfile.base`, `dev/infra/Dockerfile`,
   `dev/spark-test-image/sparkr/Dockerfile`):
   
   ```diff
   -RUN gpg -a --export E084DAB9 | apt-key add -
   +RUN gpg -a --export E084DAB9 > /etc/apt/trusted.gpg.d/cran.asc
   ```
   
   ### Why are the changes needed?
   
   `apt-key` is deprecated and removed at `Ubuntu 26.04`. The official manpage
   recommends shipping keyring files in `/etc/apt/trusted.gpg.d/` directly instead.
   
   - https://manpages.debian.org/testing/apt/apt-key.8.en.html
   - https://manpages.ubuntu.com/manpages/jammy/en/man8/apt-key.8.html
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Manually built the images and verified the CRAN repository still works.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 4.8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57755][INFRA] Replace deprecated `apt-key` with `/etc/apt/trusted.gpg.d` keyring file [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #56868:
URL: https://github.com/apache/spark/pull/56868#issuecomment-4836344729

   Could you review this when you have some time, @MaxGekk ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org