You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/03 17:38:48 UTC
[GitHub] [incubator-gobblin] sv2000 opened a new pull request #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
sv2000 opened a new pull request #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
URL: https://github.com/apache/incubator-gobblin/pull/2906
…lowGraph
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1067
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
This PR adds a new DataNode type in GaaS FlowGraph. This will allow GaaS' MultiHop flow compiler to orchetrate jobs pulling/pushing data from/to SFTP source/sinks.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Added a unit test.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] sv2000 commented on issue #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
Posted by GitBox <gi...@apache.org>.
sv2000 commented on issue #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
URL: https://github.com/apache/incubator-gobblin/pull/2906#issuecomment-594075696
@jack-moseley Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
URL: https://github.com/apache/incubator-gobblin/pull/2906
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io commented on issue #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2906: GOBBLIN-1067: Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
URL: https://github.com/apache/incubator-gobblin/pull/2906#issuecomment-594094962
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=h1) Report
> Merging [#2906](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/0de109b6941e636f4a35069752ef1e3c4188054d?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `85%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2906 +/- ##
============================================
+ Coverage 45.86% 45.86% +<.01%
- Complexity 9170 9188 +18
============================================
Files 1932 1934 +2
Lines 72789 72856 +67
Branches 8022 8032 +10
============================================
+ Hits 33386 33418 +32
- Misses 36342 36374 +32
- Partials 3061 3064 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/modules/flowgraph/datanodes/fs/SftpDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvZGF0YW5vZGVzL2ZzL1NmdHBEYXRhTm9kZS5qYXZh) | `85% <85%> (ø)` | `7 <7> (?)` | |
| [.../hive/filter/LookbackPartitionFilterGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9maWx0ZXIvTG9va2JhY2tQYXJ0aXRpb25GaWx0ZXJHZW5lcmF0b3IuamF2YQ==) | `78.94% <0%> (-21.06%)` | `6% <0%> (+3%)` | |
| [...re/ControllerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0NvbnRyb2xsZXJVc2VyRGVmaW5lZE1lc3NhZ2VIYW5kbGVyRmFjdG9yeS5qYXZh) | `39.06% <0%> (-12.5%)` | `4% <0%> (ø)` | |
| [...estli/GobblinServiceFlowConfigResourceHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9yZXN0bGkvR29iYmxpblNlcnZpY2VGbG93Q29uZmlnUmVzb3VyY2VIYW5kbGVyLmphdmE=) | `44.61% <0%> (-6.16%)` | `10% <0%> (-1%)` | |
| [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `53.71% <0%> (-4.58%)` | `19% <0%> (-2%)` | |
| [...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=) | `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | |
| [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `21.02% <0%> (-0.16%)` | `8% <0%> (ø)` | |
| [...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==) | `76.47% <0%> (-0.08%)` | `13% <0%> (ø)` | |
| [...ain/java/org/apache/gobblin/runtime/fork/Fork.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZm9yay9Gb3JrLmphdmE=) | `75% <0%> (ø)` | `68% <0%> (ø)` | :arrow_down: |
| [.../apache/gobblin/service/FlowConfigsV2Resource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnc1YyUmVzb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=footer). Last update [0de109b...ca334c8](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services