You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2022/06/11 02:50:35 UTC
[spark] branch branch-3.3 updated: [SPARK-39442][SQL][TESTS] Update `PlanStabilitySuite` comments with `SPARK_ANSI_SQL_MODE`
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.3 by this push:
new bcc646b6f3d [SPARK-39442][SQL][TESTS] Update `PlanStabilitySuite` comments with `SPARK_ANSI_SQL_MODE`
bcc646b6f3d is described below
commit bcc646b6f3da194d44db36e68d57f0f0621f10fe
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Fri Jun 10 19:50:13 2022 -0700
[SPARK-39442][SQL][TESTS] Update `PlanStabilitySuite` comments with `SPARK_ANSI_SQL_MODE`
### What changes were proposed in this pull request?
This PR aims to update `PlanStabilitySuite` direction to prevent future mistakes.
1. Add `SPARK_ANSI_SQL_MODE=true` explicitly because Apache Spark 3.3+ test coverage has ANSI and non-ANSI modes. We need to make it sure that both results are synced at the same time.
```
- SPARK_GENERATE_GOLDEN_FILES=1 build/sbt ...
+ SPARK_GENERATE_GOLDEN_FILES=1 build/sbt ...
+ SPARK_GENERATE_GOLDEN_FILES=1 SPARK_ANSI_SQL_MODE=true ...
```
2. The existing commands are human-readable but is not working. So, we had better have more simple command which is *copy-and-pasteable*.
```
- build/sbt "sql/testOnly *PlanStability[WithStats]Suite"
+ build/sbt "sql/testOnly *PlanStability*Suite"
```
### Why are the changes needed?
This will help us update the test results more easily by preventing mistakes.
### Does this PR introduce _any_ user-facing change?
No. This is a dev-only doc.
### How was this patch tested?
Manual review.
Closes #36839 from dongjoon-hyun/SPARK-39442.
Authored-by: Dongjoon Hyun <do...@apache.org>
Signed-off-by: Dongjoon Hyun <do...@apache.org>
(cherry picked from commit d426c10e94be162547fb8990434cc87bdff28380)
Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
.../test/scala/org/apache/spark/sql/PlanStabilitySuite.scala | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
index a0207e9b019..d8caf80c9a9 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
@@ -48,22 +48,24 @@ import org.apache.spark.tags.ExtendedSQLTest
*
* To run the entire test suite:
* {{{
- * build/sbt "sql/testOnly *PlanStability[WithStats]Suite"
+ * build/sbt "sql/testOnly *PlanStability*Suite"
* }}}
*
* To run a single test file upon change:
* {{{
- * build/sbt "sql/testOnly *PlanStability[WithStats]Suite -- -z (tpcds-v1.4/q49)"
+ * build/sbt "sql/testOnly *PlanStability*Suite -- -z (tpcds-v1.4/q49)"
* }}}
*
* To re-generate golden files for entire suite, run:
* {{{
- * SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *PlanStability[WithStats]Suite"
+ * SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *PlanStability*Suite"
+ * SPARK_GENERATE_GOLDEN_FILES=1 SPARK_ANSI_SQL_MODE=true build/sbt "sql/testOnly *PlanStability*Suite"
* }}}
*
* To re-generate golden file for a single test, run:
* {{{
- * SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *PlanStability[WithStats]Suite -- -z (tpcds-v1.4/q49)"
+ * SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *PlanStability*Suite -- -z (tpcds-v1.4/q49)"
+ * SPARK_GENERATE_GOLDEN_FILES=1 SPARK_ANSI_SQL_MODE=true build/sbt "sql/testOnly *PlanStability*Suite -- -z (tpcds-v1.4/q49)"
* }}}
*/
// scalastyle:on line.size.limit
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org