You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/25 12:04:04 UTC
[GitHub] [yunikorn-release] marload opened a new pull request, #118: [YUNIKORN-1429] Add ingress for Web UI
marload opened a new pull request, #118:
URL: https://github.com/apache/yunikorn-release/pull/118
Ingress is required for access from outside the cluster. Create an ingress resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] yuchaoran2011 merged pull request #118: [YUNIKORN-1429] Add ingress for Web UI
Posted by GitBox <gi...@apache.org>.
yuchaoran2011 merged PR #118:
URL: https://github.com/apache/yunikorn-release/pull/118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] marload commented on a diff in pull request #118: [YUNIKORN-1429] Add ingress for Web UI
Posted by GitBox <gi...@apache.org>.
marload commented on code in PR #118:
URL: https://github.com/apache/yunikorn-release/pull/118#discussion_r1034286297
##########
helm-charts/yunikorn/templates/ingress.yaml:
##########
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+{{- if .Values.ingress.enabled -}}
+{{- $ingressPathType := .Values.ingress.pathType -}}
+{{- $svcPort := .Values.service.portWeb -}}
Review Comment:
I reflect your review. Thanks for you review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on a diff in pull request #118: [YUNIKORN-1429] Add ingress for Web UI
Posted by GitBox <gi...@apache.org>.
craigcondit commented on code in PR #118:
URL: https://github.com/apache/yunikorn-release/pull/118#discussion_r1034147274
##########
helm-charts/yunikorn/templates/ingress.yaml:
##########
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+{{- if .Values.ingress.enabled -}}
+{{- $ingressPathType := .Values.ingress.pathType -}}
+{{- $svcPort := .Values.service.portWeb -}}
Review Comment:
I think we should only expose variables that are intended for the end user to change. Variables are not intended as shorthand for the templates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] yuchaoran2011 commented on a diff in pull request #118: [YUNIKORN-1429] Add ingress for Web UI
Posted by GitBox <gi...@apache.org>.
yuchaoran2011 commented on code in PR #118:
URL: https://github.com/apache/yunikorn-release/pull/118#discussion_r1033186970
##########
helm-charts/yunikorn/templates/ingress.yaml:
##########
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+{{- if .Values.ingress.enabled -}}
+{{- $ingressPathType := .Values.ingress.pathType -}}
+{{- $svcPort := .Values.service.portWeb -}}
Review Comment:
Nit: `.Values.ingress.pathType` and `.Values.service.portWeb` are only used once each in this file, probably no need to have variables for them. On the other hand, `.Values.ingress.tls` is referred to more than once and yet no variable is created for it. I suggest just stick to using `.Values.<conf-name>` in all places. The rest of the PR LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org