You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/01/25 06:36:48 UTC

[GitHub] chetanmeh commented on a change in pull request #4229: Add support for TTL at collection level with CosmosDB

chetanmeh commented on a change in pull request #4229: Add support for TTL at collection level with CosmosDB
URL: https://github.com/apache/incubator-openwhisk/pull/4229#discussion_r250879526
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/cosmosdb/CosmosDBConfig.scala
 ##########
 @@ -35,7 +35,8 @@ case class CosmosDBConfig(endpoint: String,
                           db: String,
                           throughput: Int,
                           consistencyLevel: ConsistencyLevel,
-                          connectionPolicy: ConnectionPolicy) {
+                          connectionPolicy: ConnectionPolicy,
+                          timeToLive: Option[Duration] = None) {
 
 Review comment:
   Want to use default of -1 here but that does not map to `Duration`. Dropped the `None` part now as pureconfig would set it anyway to None

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services