[jira] [Resolved] (SPARK-37678) Incorrect annotations in SeriesGroupBy._cleanup_and_return

["Takuya Ueshin (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-37678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Takuya Ueshin resolved SPARK-37678.
-----------------------------------
    Fix Version/s: 3.2.1
                   3.3.0
         Assignee: Maciej Szymkiewicz
       Resolution: Fixed

Issue resolved by pull request 34950
https://github.com/apache/spark/pull/34950

> Incorrect annotations in SeriesGroupBy._cleanup_and_return 
> -----------------------------------------------------------
>
>                 Key: SPARK-37678
>                 URL: https://issues.apache.org/jira/browse/SPARK-37678
>             Project: Spark
>          Issue Type: Bug
>          Components: PySpark
>    Affects Versions: 3.3.0
>            Reporter: Maciej Szymkiewicz
>            Assignee: Maciej Szymkiewicz
>            Priority: Major
>             Fix For: 3.2.1, 3.3.0
>
>
> [{{SeriesGroupBy._cleanup_and_return}}|https://github.com/apache/spark/blob/02ee1ae10b938eaa1621c3e878d07c39b9887c2e/python/pyspark/pandas/groupby.py#L2997-L2998] annotations
> {code:python}
>     def _cleanup_and_return(self, pdf: pd.DataFrame) -> Series:
>         return first_series(pdf).rename().rename(self._psser.name)
> {code}
> are inconsistent:
> - If {{pdf}} is {{pd.DataFrame}} then output should be {{pd.Series}}.
> - If output is {{ps.Series}} then {{pdf}} should be {{ps.DataFrame}}.
> Doesn't seem like the method is used (it is possible that my search skills and PyCharm inspection failed), so I am not sure which of these options was intended.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org