You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/09 22:39:40 UTC
Review Request 66014: Windows: Made SASL use default CRT linking.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66014/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
Repository: mesos
Description
-------
Windows: Made SASL use default CRT linking.
Diffs
-----
3rdparty/cyrus-sasl-2.1.27rc3.patch e363b9e92452a3558f5341faf1653514d85364d4
Diff: https://reviews.apache.org/r/66014/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 66014: Windows: Made SASL use default CRT linking.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66014/#review199464
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On March 9, 2018, 2:39 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66014/
> -----------------------------------------------------------
>
> (Updated March 9, 2018, 2:39 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-8659
> https://issues.apache.org/jira/browse/MESOS-8659
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Made SASL use default CRT linking.
>
>
> Diffs
> -----
>
> 3rdparty/cyrus-sasl-2.1.27rc3.patch e363b9e92452a3558f5341faf1653514d85364d4
>
>
> Diff: https://reviews.apache.org/r/66014/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 66014: Windows: Made SASL use default CRT linking.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66014/#review198975
-----------------------------------------------------------
PASS: Mesos patch 66014 was successfully built and tested.
Reviews applied: `['66007', '66008', '66009', '66010', '66011', '66012', '66013', '66014']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66014
- Mesos Reviewbot Windows
On March 9, 2018, 10:39 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66014/
> -----------------------------------------------------------
>
> (Updated March 9, 2018, 10:39 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-8659
> https://issues.apache.org/jira/browse/MESOS-8659
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Made SASL use default CRT linking.
>
>
> Diffs
> -----
>
> 3rdparty/cyrus-sasl-2.1.27rc3.patch e363b9e92452a3558f5341faf1653514d85364d4
>
>
> Diff: https://reviews.apache.org/r/66014/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 66014: Windows: Made SASL use default CRT linking.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66014/#review198985
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66007, 66008, 66009, 66010, 66011, 66012, 66013, 66014]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 9, 2018, 10:39 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66014/
> -----------------------------------------------------------
>
> (Updated March 9, 2018, 10:39 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-8659
> https://issues.apache.org/jira/browse/MESOS-8659
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Made SASL use default CRT linking.
>
>
> Diffs
> -----
>
> 3rdparty/cyrus-sasl-2.1.27rc3.patch e363b9e92452a3558f5341faf1653514d85364d4
>
>
> Diff: https://reviews.apache.org/r/66014/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 66014: Windows: Made SASL use default CRT linking.
Posted by John Kordich via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66014/#review198974
-----------------------------------------------------------
Ship it!
Ship It!
- John Kordich
On March 9, 2018, 10:39 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66014/
> -----------------------------------------------------------
>
> (Updated March 9, 2018, 10:39 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Made SASL use default CRT linking.
>
>
> Diffs
> -----
>
> 3rdparty/cyrus-sasl-2.1.27rc3.patch e363b9e92452a3558f5341faf1653514d85364d4
>
>
> Diff: https://reviews.apache.org/r/66014/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>