You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Shatzer, Larry" <La...@Spirent.com> on 2004/05/17 19:04:53 UTC

RE: [PATCH] add --targets to some subcommands that are missing th em.

> -----Original Message-----
> From: kfogel@collab.net [mailto:kfogel@collab.net]
> Sent: Monday, May 17, 2004 9:27 AM
> To: Shatzer, Larry
> Cc: 'dev@subversion.tigris.org'
> Subject: Re: [PATCH] add --targets to some subcommands that 
> are missing
> them.
> 
> Quick question: did you run the test suite to see if getopt_tests
> needs to be adjusted for this?  (I haven't, I just know that this is
> often a gotcha with adding options...)

Ooops! There's a test that fails now, but an easy fix.

Updated patch to include test update. This brings a question to mind, I can
see the order the option is listed will change the output from help. Should
we be putting target option earlier in the list? Or is there some cleanup in
order to make all the options in a consistent order?

> I assume you tested the new functionality itself, of course :-).

A limited check of a few areas.

-- Larry