Re: svn commit: r734699 - in /incubator/shindig/trunk/java: common/src/main/java/org/apache/shindig/common/ gadgets/src/main/java/org/apache/shindig/gadgets/ social-api/src/main/java/org/apache/shindig/social/core/util/ social-api/src/main/java/org/a

[Paul Lindner <pl...@hi5.com>]

On Jan 15, 2009, at 4:10 PM, Vincent Siveton wrote:

> Hi Paul,
>
> 2009/1/15, lindner@apache.org <li...@apache.org>:
>> Author: lindner
>> Date: Thu Jan 15 05:29:29 2009
>> New Revision: 734699
>
> [SNIP]
>
>> -            LOG.finest(file.getAbsolutePath() + " doesn't seem to  
>> be a JS or JSON file.");
>> +            if (LOG.isLoggable(Level.FINEST))  
>> LOG.finest(file.getAbsolutePath() + " doesn't seem to be a JS or  
>> JSON file.");
>
> Find and replace doesn't apply our code style :)

Not sure what you mean about this..

To insure that java doesn't evaluate the arguments you have to wrap  
the statement with lots of if-guards as above..

Re: svn commit: r734699 - in /incubator/shindig/trunk/java: common/src/main/java/org/apache/shindig/common/ gadgets/src/main/java/org/apache/shindig/gadgets/ social-api/src/main/java/org/apache/shindig/social/core/util/ social-api/src/main/java/org/a

[Vincent Siveton <vi...@gmail.com>]

Hi Paul,

2009/1/16, Paul Lindner <pl...@hi5.com>:

[SNIP]

>  Not sure what you mean about this..
>
>  To insure that java doesn't evaluate the arguments you have to wrap the
> statement with lots of if-guards as above..

Yes I know, it was the issue :)
But the codestyle used is wrong [1]

Cheers,

Vincent

[1] http://cwiki.apache.org/SHINDIGxSITE/java-style.html