You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by kemitix <gi...@git.apache.org> on 2018/09/26 11:48:36 UTC
[GitHub] brooklyn-ui pull request #74: Support for karaf 4.2.1 and running under JDK ...
GitHub user kemitix opened a pull request:
https://github.com/apache/brooklyn-ui/pull/74
Support for karaf 4.2.1 and running under JDK 11
Works with apache/brooklyn-server#1002
Removes the use of a `Service-Component` which is no longer supported by `karaf`.
Specifies the pax-web component versions as a property.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kemitix/brooklyn-ui jdk-11-runnable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-ui/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
----
commit 72dbeaaa1f861f82a04807b8ef6aa60e340d844e
Author: Paul Campbell <pa...@...>
Date: 2018-09-19T12:18:23Z
Remove deprecated/unsupported generic Service-Component
commit 5dd496e168a7f9b6620064ec7182a9ad29bf5f03
Author: Paul Campbell <pa...@...>
Date: 2018-09-26T10:16:04Z
Require that eclipse use karaf-maven-plugin 4.2.1 or later
commit 01d2172ad43bf99135c4aecf8a187f7bf16de9ad
Author: Paul Campbell <pa...@...>
Date: 2018-09-26T10:16:50Z
Specify pax-web component versions as a property
----
---
[GitHub] brooklyn-ui issue #74: Support for karaf 4.2.1 and running under JDK 11
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-ui/pull/74
retest this please
---
[GitHub] brooklyn-ui issue #74: Support for karaf 4.2.1 and running under JDK 11
Posted by kemitix <gi...@git.apache.org>.
Github user kemitix commented on the issue:
https://github.com/apache/brooklyn-ui/pull/74
:recycle:
---
[GitHub] brooklyn-ui issue #74: Support for karaf 4.2.1 and running under JDK 11
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-ui/pull/74
I've built brooklyn with this and brooklyn-server#1002, and tried running it with Java 11
```
java version "11" 2018-09-25
Java(TM) SE Runtime Environment 18.9 (build 11+28)
Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11+28, mixed mode)
```
by tweaking `setenv` as follows at line 57:
```bash
if [ "x$JAVA_HOME" = "x" ] && [ "$darwin" = "true" ]; then
JAVA_HOME="$(/usr/libexec/java_home -v 11)"
fi
```
This runs brooklyn:
```
ps aux | grep karaf
geoff 28307 1.0 2.4 8245476 410588 s001 S 10:08pm 0:22.25 /Library/Java/JavaVirtualMachines/jdk-11.jdk/Contents/Home/bin/java -Xms128M -Xmx2G -XX:+UnlockDiagnosticVMOptions -Dcom.sun.management.jmxremote -Dbrooklyn.persistence.dir=~/.brooklyn/brooklyn-persisted-state
..etc etc etc...
...org.apache.karaf.main.Main
```
but brooklyn fails to start with a bunch of `Unresolved requirements` errors. I've attached the `brooklyn.info.log`.
Is this the wrong way to go about testing this?
[info.log](https://github.com/apache/brooklyn-ui/files/2425938/info.log)
---
[GitHub] brooklyn-ui pull request #74: Support for karaf 4.2.1 and running under JDK ...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/74#discussion_r220589038
--- Diff: pom.xml ---
@@ -99,7 +99,8 @@
<maven-resources-plugin.version>3.0.1</maven-resources-plugin.version>
<maven-war-plugin.version>3.0.0</maven-war-plugin.version>
<frontend-maven-plugin.version>1.3</frontend-maven-plugin.version>
- <pax-web-extender-whiteboard.version>6.0.6</pax-web-extender-whiteboard.version>
+ <pax-web.version>6.0.6</pax-web.version>
--- End diff --
Do we need to redeclare this here? Or can we just inherit it from brooklyn-server's pom.xml (which it should get from its parent).
---
[GitHub] brooklyn-ui issue #74: Support for karaf 4.2.1 and running under JDK 11
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/74
retest this please
---
[GitHub] brooklyn-ui pull request #74: Support for karaf 4.2.1 and running under JDK ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-ui/pull/74
---
[GitHub] brooklyn-ui pull request #74: Support for karaf 4.2.1 and running under JDK ...
Posted by kemitix <gi...@git.apache.org>.
Github user kemitix commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/74#discussion_r220598129
--- Diff: pom.xml ---
@@ -99,7 +99,8 @@
<maven-resources-plugin.version>3.0.1</maven-resources-plugin.version>
<maven-war-plugin.version>3.0.0</maven-war-plugin.version>
<frontend-maven-plugin.version>1.3</frontend-maven-plugin.version>
- <pax-web-extender-whiteboard.version>6.0.6</pax-web-extender-whiteboard.version>
+ <pax-web.version>6.0.6</pax-web.version>
--- End diff --
I should remove it.
I think I was having problems building `brooklyn-ui` independent of the main `apache/brooklyn` project and it was pulling the `brooklyn-server` snapshot from the repo rather than my previously built locally copy.
---
[GitHub] brooklyn-ui issue #74: Support for karaf 4.2.1 and running under JDK 11
Posted by kemitix <gi...@git.apache.org>.
Github user kemitix commented on the issue:
https://github.com/apache/brooklyn-ui/pull/74
retest this please
---
[GitHub] brooklyn-ui issue #74: Support for karaf 4.2.1 and running under JDK 11
Posted by kemitix <gi...@git.apache.org>.
Github user kemitix commented on the issue:
https://github.com/apache/brooklyn-ui/pull/74
@geomacy I made a couple of additional pushes yesterday to the `brooklyn-server` PR that I think should clear those missing dependencies.
---
[GitHub] brooklyn-ui issue #74: Support for karaf 4.2.1 and running under JDK 11
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-ui/pull/74
LGTM, thanks a lot @kemitix !
Jenkins failed but that is because this requires https://github.com/apache/brooklyn-server/pull/1002 to be merged first. Will trigger another build then
---