You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Paul Rogers (Code Review)" <ge...@cloudera.org> on 2018/11/22 00:02:42 UTC
[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11980
Change subject: IMPALA-7881: Visualize AST for easier debugging
......................................................................
IMPALA-7881: Visualize AST for easier debugging
Provides a debug-time class to visualize the analysis-time AST for use
by developers. Uses a very simple JSON-like output. See IMPALA-7881 for
an example. Emphasize simplicity over elegance, many refinements can
follow.
Tests: This is test only code that is not even called from anywhere. A
developer must insert a temporary call when doing debugging. As a
result, the code cannot impact any other part of the code base.
Change-Id: Ia083c63953ceec0abedd2e0753b9444c19fcd114
---
A fe/src/test/java/org/apache/impala/util/treevis/AstPrinter.java
A fe/src/test/java/org/apache/impala/util/treevis/TreePrinter.java
A fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java
3 files changed, 393 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/11980/1
--
To view, visit http://gerrit.cloudera.org:8080/11980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia083c63953ceec0abedd2e0753b9444c19fcd114
Gerrit-Change-Number: 11980
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11980 )
Change subject: IMPALA-7881: Visualize AST for easier debugging
......................................................................
IMPALA-7881: Visualize AST for easier debugging
Provides a debug-time class to visualize the analysis-time AST for use
by developers. Uses a very simple JSON-like output. See IMPALA-7881 for
an example. Emphasize simplicity over elegance, many refinements can
follow.
Tests: This is test only code that is not even called from anywhere. A
developer must insert a temporary call when doing debugging. As a
result, the code cannot impact any other part of the code base.
Change-Id: Ia083c63953ceec0abedd2e0753b9444c19fcd114
Reviewed-on: http://gerrit.cloudera.org:8080/11980
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
A fe/src/test/java/org/apache/impala/util/treevis/AstPrinter.java
A fe/src/test/java/org/apache/impala/util/treevis/TreePrinter.java
A fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java
3 files changed, 393 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
Lars Volker: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/11980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia083c63953ceec0abedd2e0753b9444c19fcd114
Gerrit-Change-Number: 11980
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 )
Change subject: IMPALA-7881: Visualize AST for easier debugging
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia083c63953ceec0abedd2e0753b9444c19fcd114
Gerrit-Change-Number: 11980
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Nov 2018 04:36:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 )
Change subject: IMPALA-7881: Visualize AST for easier debugging
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3488/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia083c63953ceec0abedd2e0753b9444c19fcd114
Gerrit-Change-Number: 11980
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Nov 2018 00:23:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 )
Change subject: IMPALA-7881: Visualize AST for easier debugging
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11980/1/fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java
File fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java:
http://gerrit.cloudera.org:8080/#/c/11980/1/fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java@135
PS1, Line 135: } catch (IllegalAccessException | IllegalArgumentException | InvocationTargetException e) {
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/11980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia083c63953ceec0abedd2e0753b9444c19fcd114
Gerrit-Change-Number: 11980
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Nov 2018 00:03:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 )
Change subject: IMPALA-7881: Visualize AST for easier debugging
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1428/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia083c63953ceec0abedd2e0753b9444c19fcd114
Gerrit-Change-Number: 11980
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Nov 2018 00:39:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 )
Change subject: IMPALA-7881: Visualize AST for easier debugging
......................................................................
Patch Set 1: Code-Review+2
I'm inclined to go ahead and merge this since it's just for debugging. I checked the code for readability and general sanity. It seems expedient to merge it - then other people can try it out and make any tweaks that they would like if the current output isn't to their liking.
--
To view, visit http://gerrit.cloudera.org:8080/11980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia083c63953ceec0abedd2e0753b9444c19fcd114
Gerrit-Change-Number: 11980
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Nov 2018 00:23:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 )
Change subject: IMPALA-7881: Visualize AST for easier debugging
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
I had a look because I was curious and had a small nit.
http://gerrit.cloudera.org:8080/#/c/11980/2/fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java
File fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java:
http://gerrit.cloudera.org:8080/#/c/11980/2/fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java@77
PS2, Line 77: private TreeVisualizer treeVis;
nit: I think we end member variables with an _ in Java, too.
http://gerrit.cloudera.org:8080/#/c/11980/2/fe/src/test/java/org/apache/impala/util/treevis/Visualizer.java@124
PS2, Line 124: Method visMethod;
On first glance I found this a bit tricky to read since visit and visualize both start with "vis". Maybe "print" or "render" are alternatives to "visualize", or just "visualizeMethod"?
--
To view, visit http://gerrit.cloudera.org:8080/11980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia083c63953ceec0abedd2e0753b9444c19fcd114
Gerrit-Change-Number: 11980
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Nov 2018 03:09:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 )
Change subject: IMPALA-7881: Visualize AST for easier debugging
......................................................................
Patch Set 2:
Pretty cool, thanks for doing this.
--
To view, visit http://gerrit.cloudera.org:8080/11980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia083c63953ceec0abedd2e0753b9444c19fcd114
Gerrit-Change-Number: 11980
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Nov 2018 01:25:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 )
Change subject: IMPALA-7881: Visualize AST for easier debugging
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia083c63953ceec0abedd2e0753b9444c19fcd114
Gerrit-Change-Number: 11980
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Nov 2018 00:23:26 +0000
Gerrit-HasComments: No