[jira] [Commented] (CARBONDATA-273) Some constants should be written using carbon common constants instead of direct values

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CARBONDATA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522454#comment-15522454 ] 

ASF GitHub Bot commented on CARBONDATA-273:
-------------------------------------------

GitHub user foryou2030 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/198

    [CARBONDATA-273]Using carbon common constants instead of direct values

    # Why raise this pr?
    there are some constants hav been defined in CarbonCommonConstants, but sitill using its direct value in the code.
    # How to solve?
    Using carbon common constants instead of direct values


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/foryou2030/incubator-carbondata utf8

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #198
    
----
commit 28ea756774f43e76b6988a96451aa8b13993e83a
Author: foryou2030 <fo...@126.com>
Date:   2016-09-26T08:25:38Z

    use carbon common constants instead of direct values

----


> Some constants should be written using carbon common constants instead of direct values
> ---------------------------------------------------------------------------------------
>
>                 Key: CARBONDATA-273
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-273
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Gin-zhj
>            Assignee: Gin-zhj
>            Priority: Minor
>
> such as,
> "UTF-8" for charset, 'default" for database



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)