You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/21 12:24:57 UTC

[GitHub] [flink-kubernetes-operator] bgeng777 edited a comment on pull request #9: [FLINK-26163] Refactor FlinkUtils#getEffectiveConfig into smaller pieces

bgeng777 edited a comment on pull request #9:
URL: https://github.com/apache/flink-kubernetes-operator/pull/9#issuecomment-1046823084


   1. Sure. It seems that the fix of JM replicas is just some lines of codes so I did it here. I will move it out and leave the work to the separate [jira](https://issues.apache.org/jira/browse/FLINK-26216) for better tracking.
   2. My bad. Check the `KUBERNETES_POD_TEMPLATE` field again and I understood it wrongly before.
   3. Yes, I also think about using Builder pattern when refactoring. Considering not to change the code style too much, I did not use it initially. But I believe it could make codes more neat. Will update it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org