You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2023/03/08 04:59:23 UTC
[GitHub] [netbeans] mbien opened a new pull request, #5625: option window layout adjustments and UI fixes.
mbien opened a new pull request, #5625:
URL: https://github.com/apache/netbeans/pull/5625
consistent (+symmetric) insets, margins, improved widget positioning and layout fixes. fixes #4973
some of those were quite hard to find + cascading JScrollPanes are my nemesis.
Screenshots:
old then new - those aren't all but most of them, at some point I gave up taking screenshots.
as bonus: template manager and DTD/XML Schema manager:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5625: option window layout adjustments and UI fixes.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5625:
URL: https://github.com/apache/netbeans/pull/5625#issuecomment-1459619507
[option-window.zip](https://github.com/apache/netbeans/files/10917848/option-window.zip) added a zip with the images. Makes it easier to inspect if you don't have to scroll.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #5625: option window layout adjustments and UI fixes.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #5625:
URL: https://github.com/apache/netbeans/pull/5625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #5625: option window layout adjustments and UI fixes.
Posted by "Chris2011 (via GitHub)" <gi...@apache.org>.
Chris2011 commented on PR #5625:
URL: https://github.com/apache/netbeans/pull/5625#issuecomment-1460882943
Oh I see, I was a bit late to the party. Sry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #5625: option window layout adjustments and UI fixes.
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on PR #5625:
URL: https://github.com/apache/netbeans/pull/5625#issuecomment-1460057838
There were a couple of spots in the code I might have made a comment. But decided not to as it was so minor.
Nice work! I really had to "look" at some of those screenshots to see the difference. 8-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5625: option window layout adjustments and UI fixes.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5625:
URL: https://github.com/apache/netbeans/pull/5625#issuecomment-1460529494
@BradWalker my original plan was to mark the changes in the screenshot. But after taking so many it would have been too much work using gimp. The second idea was to use the `mouseover` feature of the img tag to switch between images on hover, but github doesn't support it either.
So the easiest way to see the difference is to download the zip, open an image with a viewer tool and quickly toggle with the arrow keys between before/after. Some changes only make sense in context, e.g if you switch between tabs in the UI.
Looking at the linked issue can also help to know what to look for.
@eirikbakke the UI snapshot feature of the debugging session was vital to find where stuff is implemented. It allows to jump directly to the implementation. Although some layout issues were super sneaky, e.g some code somewhere else adding a empty border with insets to patch something, or even worse: code replacing components, borders or even layout managers outside of the actual component code.
thanks everyone for review. I will do another manual test and then merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #5625: option window layout adjustments and UI fixes.
Posted by "Chris2011 (via GitHub)" <gi...@apache.org>.
Chris2011 commented on PR #5625:
URL: https://github.com/apache/netbeans/pull/5625#issuecomment-1460882061
I think it should be aligned with the text field, a bit smaller, because it is to prominent and just a hint for the field. Maybe also the brackets can be removed
Current
Potential solution
<img width="321" alt="maven version" src="https://user-images.githubusercontent.com/795658/223700867-6bf2317f-ff1c-41d2-802f-e752f7942368.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #5625: option window layout adjustments and UI fixes.
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #5625:
URL: https://github.com/apache/netbeans/pull/5625#issuecomment-1460652508
Yeah, the UI Snapshot feature is really useful, especially for inspecting form layouts in NetBeans itself.
To compare before/after images, I usually just open each image in a different Chrome tab (Ctrl+Click the image to open just the image in a new tab) and do Ctrl+PgUp/PgDown to switch between them. Or for downloaded images on Windows, I use IrfanView as my image viewer of choice (press enter twice to full-screen, then left/right arrows to switch between images in the same folder).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists