[GitHub] [nifi] bbende commented on issue #3425: NIFI-6197 HBase: Fix deprecations, default for client retries & validations

[GitBox <gi...@apache.org>]

bbende commented on issue #3425: NIFI-6197 HBase: Fix deprecations, default for client retries & validations
URL: https://github.com/apache/nifi/pull/3425#issuecomment-482189089
 
 
   Overall the code looks good. I'm still on the fence about removing the default value for retries...  
   
   I believe the most common scenario where people encounter the retries is during initial setup of the service when they have misconfigured something, or have a network issue, and in that case having the service retrying 31 or 15 times in the background with no info in the NiFi UI is not very helpful because its not going to ever work, and with increased delays it may take many minutes to wait for it finish and many users believing it is stuck. 
   
   I'd be onboard increasing to something like 5, and then for users like yourself that believe you need it higher then you can always change it to whatever you like. Also, the 1_1_2 client service currently uses the 1.1.13 hbase-client which still has 31 retries which is way too much.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services