You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Zita Dombi (Jira)" <ji...@apache.org> on 2021/10/13 14:05:00 UTC
[jira] [Comment Edited] (HDDS-5722) [HTTPFSGGW] junit.jar and
json-simple in jar report
[ https://issues.apache.org/jira/browse/HDDS-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428244#comment-17428244 ]
Zita Dombi edited comment on HDDS-5722 at 10/13/21, 2:04 PM:
-------------------------------------------------------------
So I looked a bit more into this problem. We found that the junit.jar is coming from the json-simple.jar as a compile time dependency, so that can be excluded in the pom.xml.
I found that the json-smart.jar, which is already in the jar-report.txt, is added as a "hack". In the ozone-main pom.xml this is added as a comment where we include the json-smart dependency:
"HACK. Transitive dependency for nimbus-jose-jwt. Needed for
packaging. Please re-check this version when updating
nimbus-jose-jwt. Please read HADOOP-14903 for more details."
We agreed not to use json-smart instead of json-simple, as json-smart is planned to be removed in the future. Classes in the httpfsgateway are using json-simple (JSONObject, JSONArray, JSONParser, etc.), so we need that.
was (Author: zitadombi):
So I looked a bit more into this problem. We found that the junit.jar is coming from the json-simple.jar as a compile time dependency, so that can be excluded in the pom.xml.
I found that the json-smart.jar, which is already in the jar-report.txt, is added as a "hack". In the ozone-main pom.xml this is added as a comment where we include the json-smart dependency:
"HACK. Transitive dependency for nimbus-jose-jwt. Needed for
packaging. Please re-check this version when updating
nimbus-jose-jwt. Please read [#HADOOP-14903] for more details."
We agreed not to use json-smart instead of json-simple, as json-smart is planned to be removed in the future. Classes in the httpfsgateway are using json-simple (JSONObject, JSONArray, JSONParser, etc.), so we need that.
> [HTTPFSGGW] junit.jar and json-simple in jar report
> ---------------------------------------------------
>
> Key: HDDS-5722
> URL: https://issues.apache.org/jira/browse/HDDS-5722
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: István Fajth
> Assignee: Zita Dombi
> Priority: Major
>
> The HTTPFS branch contains junit.jar, and json-simple.jar in its jar-report.txt.
> Junit.jar we surely not need there, and we should look at why it is ending up there, probably it is not added as a test only dependency.
> Instead of usingg json-simple.jar, we should try to switch to json-smart, we already have in the project, and move functionality to use the same or similar functions from there.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org