You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by jl...@apache.org on 2009/12/23 15:27:30 UTC
svn commit: r893523 -
/openejb/trunk/openejb3/assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/apache/openejb/tomcat/catalina/TomcatSecurityService.java
Author: jlmonteiro
Date: Wed Dec 23 14:27:30 2009
New Revision: 893523
URL: http://svn.apache.org/viewvc?rev=893523&view=rev
Log:
OPENEJB-1120: TomcatSecurityService should grant the guest role when no user is logged in.
The behavior was not the same with the SecurityServiceImpl.
Thanks Luis!
Modified:
openejb/trunk/openejb3/assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/apache/openejb/tomcat/catalina/TomcatSecurityService.java
Modified: openejb/trunk/openejb3/assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/apache/openejb/tomcat/catalina/TomcatSecurityService.java
URL: http://svn.apache.org/viewvc/openejb/trunk/openejb3/assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/apache/openejb/tomcat/catalina/TomcatSecurityService.java?rev=893523&r1=893522&r2=893523&view=diff
==============================================================================
--- openejb/trunk/openejb3/assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/apache/openejb/tomcat/catalina/TomcatSecurityService.java (original)
+++ openejb/trunk/openejb3/assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/java/org/apache/openejb/tomcat/catalina/TomcatSecurityService.java Wed Dec 23 14:27:30 2009
@@ -88,9 +88,8 @@
roles.add(logicalRole);
break;
}
- } else if (principal instanceof RunAsRole) {
- RunAsRole runAsRole = (RunAsRole) principal;
- String name = runAsRole.getName();
+ } else if (principal != null) {
+ String name = principal.getName();
if (logicalRole.equals(name)) {
roles.add(logicalRole);
}