[GitHub] yanghua commented on a change in pull request #6927: [FLINK-10624] Extend SQL client end-to-end to test new KafkaTableSink

[GitBox <gi...@apache.org>]

yanghua commented on a change in pull request #6927: [FLINK-10624] Extend SQL client end-to-end to test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#discussion_r231793883
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_sql_client_common.sh
 ##########
 @@ -17,8 +17,6 @@
 # limitations under the License.
 ################################################################################
 
-set -Eeuo pipefail
 
 Review comment:
   @pnowojski 
   
   > @yanghua please do not trigger rebuild of errors like this:
   > 
   > ```
   > Waiting for Elasticsearch node to work...
   > curl: (7) Failed to connect to localhost port 9200: Connection refused
   > curl: (7) Failed to connect to localhost port 9200: Connection refused
   > 
   > [FAIL] 'SQL Client end-to-end test' failed after 0 minutes and 29 seconds! Test exited with exit code 7
   > ```
   > In the test that you are just adding. This test must be fixed in someway.
   
   I should have found the cause of this problem. We can't enable this setting here, because curl is constantly retrying until it is accessible, and when this setting is added, it will report a connection error.
   
   Another exception is the known FLINK-10801. As a temporary treatment, I will use sleep again to fix it (to quickly verify other parts).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services