[jira] [Commented] (KNOX-647) Rename LDAP artifacts from test to demo

["Kevin Minder (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KNOX-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098416#comment-15098416 ] 

Kevin Minder commented on KNOX-647:
-----------------------------------

>From email...

[~sumit.gupta]
{quote}
The patch looks like a simple (i.e. harmless) refactor/rename to me. I
don¹t see any upgrade issues unless people are writing their own
launchers, which doesn¹t make sense. In any case no one should be using
the test/demo ldap in production.

+1
{quote}

[~lmccay@apache.org]
{quote}
I agree with Sumit.

As long as none of the scripting that is used by Ambari is explicitly
referencing the jar and no classes/packages are renamed out from under a
script then rolling upgrades and Ambari support for various versions should
remain intact.

I don't see any reason for this to affect 0.8.0 planning and I see it as a
bug fix that should be included in 0.8.0.

If anyone disagrees then we can discuss branching for 0.8.0 now and
committing this to master only.

+1 on the patch as it stands.
{quote}

Given the feedback I'll go ahead and push this to master.

> Rename LDAP artifacts from test to demo
> ---------------------------------------
>
>                 Key: KNOX-647
>                 URL: https://issues.apache.org/jira/browse/KNOX-647
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Server
>    Affects Versions: 0.7.0
>            Reporter: Kevin Minder
>            Assignee: Kevin Minder
>             Fix For: 0.8.0
>
>         Attachments: 0001-KNOX-647-Rename-LDAP-artifacts-from-test-to-demo.patch
>
>
> The demo LDAP server that is provided with Knox has various artifacts that are include the word test.  This is causing some confusion especially with various static code/file scans being done.  All of the source and binary files for the demo LDAP server should replace the use of test with demo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)