svn commit: r344366 - /webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/transport/http/CommonsHTTPTransportSender.java

[st...@apache.org]

Author: stevel
Date: Tue Nov 15 05:33:12 2005
New Revision: 344366

URL: http://svn.apache.org/viewcvs?rev=344366&view=rev
Log:
no, we do not want the ?string as the path to a request. Setting the path is probably entirely gratuitous if the constructor worked correctly, but deleting this line is left to someone more knowledgeable of httpclient.

Modified:
    webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/transport/http/CommonsHTTPTransportSender.java

Modified: webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/transport/http/CommonsHTTPTransportSender.java
URL: http://svn.apache.org/viewcvs/webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/transport/http/CommonsHTTPTransportSender.java?rev=344366&r1=344365&r2=344366&view=diff
==============================================================================
--- webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/transport/http/CommonsHTTPTransportSender.java (original)
+++ webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/transport/http/CommonsHTTPTransportSender.java Tue Nov 15 05:33:12 2005
@@ -85,6 +85,11 @@
 
     protected Log log = LogFactory.getLog(getClass().getName());
 
+    /**
+     * {@value}
+     */
+    private static final String ANONYMOUS = "anonymous";
+
     public CommonsHTTPTransportSender() {
     } //default
 
@@ -462,7 +467,7 @@
         //HostConfiguration hostConfig = getHostConfiguration(msgContext, url);
 
         //Get the timeout values set in the runtime
-        getTimoutValues(msgContext);
+        getTimeoutValues(msgContext);
 
         // SO_TIMEOUT -- timeout for blocking reads
         httpClient.getHttpConnectionManager().getParams().setSoTimeout(soTimeout);
@@ -472,7 +477,7 @@
         //todo giving proxy and NTLM support
 
         PostMethod postMethod = new PostMethod(url.toString());
-        postMethod.setPath(url.getFile());
+        postMethod.setPath(url.getPath());
 
         msgContext.setProperty(HTTP_METHOD, postMethod);
 
@@ -563,7 +568,7 @@
      *
      * @param msgContext
      */
-    private void getTimoutValues(MessageContext msgContext) {
+    private void getTimeoutValues(MessageContext msgContext) {
         try {
             // If the SO_TIMEOUT of CONNECTION_TIMEOUT is set by dynamically the
             // override the static config
@@ -622,7 +627,7 @@
         //this.getHostConfiguration(msgContext, url);
 
         //Get the timeout values set in the runtime
-        getTimoutValues(msgContext);
+        getTimeoutValues(msgContext);
 
         // SO_TIMEOUT -- timeout for blocking reads
         httpClient.getHttpConnectionManager().getParams().setSoTimeout(soTimeout);
@@ -792,8 +797,8 @@
 
         }
 
-        if (domain.equals("") || domain == null || domain.equals("anonymous")) {
-            if (usrName.equals("anonymous") && passwd.equals("anonymous")) {
+        if (domain.equals("") || domain == null || domain.equals(ANONYMOUS)) {
+            if (usrName.equals(ANONYMOUS) && passwd.equals(ANONYMOUS)) {
                 proxyCred = new UsernamePasswordCredentials("", "");
             } else {
                 proxyCred = new UsernamePasswordCredentials(usrName,
@@ -815,7 +820,7 @@
             } else {
                 throw new AxisFault("Proxy Name is not valied");
             }
-            if (proxyProperties.getUserName().equals("anonymous") || proxyProperties.getPassWord().equals("anonymous")) {
+            if (proxyProperties.getUserName().equals(ANONYMOUS) || proxyProperties.getPassWord().equals(ANONYMOUS)) {
                 proxyCred = new UsernamePasswordCredentials("", "");
             } else {
                 usrName = proxyProperties.getUserName();