You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/15 10:31:54 UTC

[GitHub] [spark] attilapiros commented on pull request #29855: [SPARK-32915][CORE] Network-layer and shuffle RPC layer changes to support push shuffle blocks

attilapiros commented on pull request #29855:
URL: https://github.com/apache/spark/pull/29855#issuecomment-709123067


   I do not like the error message check (the string contain) but as it it is promised to be addressed in a follow-up PR https://github.com/apache/spark/pull/29855#discussion_r502788433, it is fine now.
   
   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org