You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/23 17:49:59 UTC

[GitHub] [spark] hensg opened a new pull request #26989: [SPARK-26604][CORE][BACKPORT-1.6] Clean up channel registration for S…

hensg opened a new pull request #26989: [SPARK-26604][CORE][BACKPORT-1.6] Clean up channel registration for S…
URL: https://github.com/apache/spark/pull/26989
 
 
   …treamManager
   
    ## What changes were proposed in this pull request?
   
   This is mostly a clean backport of #23521 to branch-1.6
   
    ## How was this patch tested?
   
   I've tested this debugging local NodeManager using ExternalShuffleService.
   I've run spark applications and abruptly killing them after registering streams on ExternalShuffleBlockHandler.
   
   jvisualvm heap dumps show that OneForOneStreamManager$StreamState references are unreachable.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] vanzin closed pull request #26989: [SPARK-26604][CORE][BACKPORT-1.6] Clean up channel registration for S…

Posted by GitBox <gi...@apache.org>.
vanzin closed pull request #26989: [SPARK-26604][CORE][BACKPORT-1.6] Clean up channel registration for S…
URL: https://github.com/apache/spark/pull/26989
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] vanzin commented on issue #26989: [SPARK-26604][CORE][BACKPORT-1.6] Clean up channel registration for S…

Posted by GitBox <gi...@apache.org>.
vanzin commented on issue #26989: [SPARK-26604][CORE][BACKPORT-1.6] Clean up channel registration for S…
URL: https://github.com/apache/spark/pull/26989#issuecomment-568546307
 
 
   Sorry, but 1.6 has been EOL forever. We don't even have a way of testing it anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] hensg commented on issue #26989: [SPARK-26604][CORE][BACKPORT-1.6] Clean up channel registration for S…

Posted by GitBox <gi...@apache.org>.
hensg commented on issue #26989: [SPARK-26604][CORE][BACKPORT-1.6] Clean up channel registration for S…
URL: https://github.com/apache/spark/pull/26989#issuecomment-568548971
 
 
   We still using it on our cluster and would be nice to have this fix

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] hensg removed a comment on issue #26989: [SPARK-26604][CORE][BACKPORT-1.6] Clean up channel registration for S…

Posted by GitBox <gi...@apache.org>.
hensg removed a comment on issue #26989: [SPARK-26604][CORE][BACKPORT-1.6] Clean up channel registration for S…
URL: https://github.com/apache/spark/pull/26989#issuecomment-568548971
 
 
   We still using it on our cluster and would be nice to have this fix

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org