You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/16 03:38:06 UTC

[GitHub] [pulsar] liangyepianzhou opened a new pull request, #15614: [doc][config]Add missing transaction config in standalone.conf and broker.conf

liangyepianzhou opened a new pull request, #15614:
URL: https://github.com/apache/pulsar/pull/15614

   ### Motivation & Modification
   Add missing transaction config in standalone.conf and broker.conf
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [ ] `no-need-doc` 
   (Please explain why)
     
   - [x] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-added`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] momo-jun commented on a diff in pull request #15614: [feature][doc][config]Add missing transaction config in standalone.conf and broker.conf

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15614:
URL: https://github.com/apache/pulsar/pull/15614#discussion_r874419327


##########
site2/docs/reference-configuration.md:
##########
@@ -338,8 +338,12 @@ brokerServiceCompactionThresholdInBytes| If the estimated backlog size is greate
 |replicationProducerQueueSize| Replicator producer queue size                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |1000|
 |replicatorPrefix| Replicator prefix used for replicator producer name and cursor name pulsar.repl                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ||
 |transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |3000|
-|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |true|
-|transactionMetadataStoreProviderClassName|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |org.apache.pulsar.transaction.coordinator.impl.InMemTransactionMetadataStoreProvider|
+|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |false|
+|transactionMetadataStoreProviderClassName|The class name of transactionMetadataStoreProvider.|org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider|
+|transactionBufferSnapshotMaxTransactionCount|Transaction buffer takes a snapshot after the number of transaction operations reaches this value.|1000|
+|transactionBufferSnapshotMinTimeInMillis|The interval time of transaction buffer takes a snapshot (in milliseconds).|5000|
+|transactionPendingAckLogIndexMinLag|MLPendingAckStore maintains a ConcurrentSkipListMap pendingAckLogIndex. PendingAckLogIndex stores the position in pendingAckStore as its value and saves a position used to determine whether the previous data can be cleaned up as a key. transactionPendingAckLogIndexMinLag is used to configure the minimum lag between indexes (keys).|500|

Review Comment:
   ```suggestion
   |transactionPendingAckLogIndexMinLag| The minimum lag between indexes (keys) used to determine whether the previous data can be cleaned up.|500|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] momo-jun commented on a diff in pull request #15614: [feature][doc][config]Add missing transaction config in standalone.conf and broker.conf

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15614:
URL: https://github.com/apache/pulsar/pull/15614#discussion_r874419327


##########
site2/docs/reference-configuration.md:
##########
@@ -338,8 +338,12 @@ brokerServiceCompactionThresholdInBytes| If the estimated backlog size is greate
 |replicationProducerQueueSize| Replicator producer queue size                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |1000|
 |replicatorPrefix| Replicator prefix used for replicator producer name and cursor name pulsar.repl                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ||
 |transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |3000|
-|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |true|
-|transactionMetadataStoreProviderClassName|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |org.apache.pulsar.transaction.coordinator.impl.InMemTransactionMetadataStoreProvider|
+|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |false|
+|transactionMetadataStoreProviderClassName|The class name of transactionMetadataStoreProvider.|org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider|
+|transactionBufferSnapshotMaxTransactionCount|Transaction buffer takes a snapshot after the number of transaction operations reaches this value.|1000|
+|transactionBufferSnapshotMinTimeInMillis|The interval time of transaction buffer takes a snapshot (in milliseconds).|5000|
+|transactionPendingAckLogIndexMinLag|MLPendingAckStore maintains a ConcurrentSkipListMap pendingAckLogIndex. PendingAckLogIndex stores the position in pendingAckStore as its value and saves a position used to determine whether the previous data can be cleaned up as a key. transactionPendingAckLogIndexMinLag is used to configure the minimum lag between indexes (keys).|500|

Review Comment:
   ```suggestion
   |transactionPendingAckLogIndexMinLag| The minimum lag between transaction pendingAck log indexes (keys). It can be used to determine the cleanup frequency of transaction pendingAck logs. Setting a larger lag leads to more hard disk resource consumption; setting a smaller lag leads to more memory consumption. |500|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] congbobo184 merged pull request #15614: [feature][doc][config]Add missing transaction config in standalone.conf and broker.conf

Posted by GitBox <gi...@apache.org>.
congbobo184 merged PR #15614:
URL: https://github.com/apache/pulsar/pull/15614


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] congbobo184 commented on a diff in pull request #15614: [doc][config]Add missing transaction config in standalone.conf and broker.conf

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on code in PR #15614:
URL: https://github.com/apache/pulsar/pull/15614#discussion_r873311475


##########
site2/docs/reference-configuration.md:
##########
@@ -337,9 +337,13 @@ brokerServiceCompactionThresholdInBytes| If the estimated backlog size is greate
 |replicationConnectionsPerBroker| Max number of connections to open for each broker in a remote cluster More connections host-to-host lead to better throughput over high-latency links.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |16|
 |replicationProducerQueueSize| Replicator producer queue size                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |1000|
 |replicatorPrefix| Replicator prefix used for replicator producer name and cursor name pulsar.repl                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ||
-|transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |3000|
-|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |true|
-|transactionMetadataStoreProviderClassName|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |org.apache.pulsar.transaction.coordinator.impl.InMemTransactionMetadataStoreProvider|
+|transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds.|3000|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |3000|
+|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.|false|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |true|

Review Comment:
   wht false and true



##########
site2/docs/reference-configuration.md:
##########
@@ -337,9 +337,13 @@ brokerServiceCompactionThresholdInBytes| If the estimated backlog size is greate
 |replicationConnectionsPerBroker| Max number of connections to open for each broker in a remote cluster More connections host-to-host lead to better throughput over high-latency links.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |16|
 |replicationProducerQueueSize| Replicator producer queue size                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |1000|
 |replicatorPrefix| Replicator prefix used for replicator producer name and cursor name pulsar.repl                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ||
-|transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |3000|
-|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |true|
-|transactionMetadataStoreProviderClassName|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |org.apache.pulsar.transaction.coordinator.impl.InMemTransactionMetadataStoreProvider|
+|transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds.|3000|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |3000|

Review Comment:
   two 3000



##########
conf/broker.conf:
##########
@@ -1396,7 +1396,7 @@ transactionCoordinatorEnabled=false
 transactionMetadataStoreProviderClassName=org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider
 
 # Transaction buffer take snapshot transaction count
-transactionBufferSnapshotMaxTransactionCount=1000
+transactionBufferSnapshotMinTransactionCount=1000

Review Comment:
   why change this to min transaction count?



##########
site2/docs/reference-configuration.md:
##########
@@ -708,7 +712,11 @@ You can set the log level and configuration in the  [log4j2.yaml](https://github
 |replicationConnectionsPerBroker|   |16|
 |replicationProducerQueueSize|    |1000|
 | replicationPolicyCheckDurationSeconds | Duration to check replication policy to avoid replicator inconsistency due to missing ZooKeeper watch. When the value is set to 0, disable checking replication policy. | 600 |
+|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.|false|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |true|

Review Comment:
   true and false



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] momo-jun commented on pull request #15614: [doc][config]Add missing transaction config in standalone.conf and broker.conf

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15614:
URL: https://github.com/apache/pulsar/pull/15614#issuecomment-1128330895

   @liangyepianzhou this PR adds not only missing configs but also new configs to align with #15137, correct? 
   If yes, can you please follow the PR naming convention to add [feature] ahead of [doc] to show the dependency with #15137? This will help everyone to better understand your PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] momo-jun commented on a diff in pull request #15614: [feature][doc][config]Add missing transaction config in standalone.conf and broker.conf

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15614:
URL: https://github.com/apache/pulsar/pull/15614#discussion_r874419327


##########
site2/docs/reference-configuration.md:
##########
@@ -338,8 +338,12 @@ brokerServiceCompactionThresholdInBytes| If the estimated backlog size is greate
 |replicationProducerQueueSize| Replicator producer queue size                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |1000|
 |replicatorPrefix| Replicator prefix used for replicator producer name and cursor name pulsar.repl                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ||
 |transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |3000|
-|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |true|
-|transactionMetadataStoreProviderClassName|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |org.apache.pulsar.transaction.coordinator.impl.InMemTransactionMetadataStoreProvider|
+|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |false|
+|transactionMetadataStoreProviderClassName|The class name of transactionMetadataStoreProvider.|org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider|
+|transactionBufferSnapshotMaxTransactionCount|Transaction buffer takes a snapshot after the number of transaction operations reaches this value.|1000|
+|transactionBufferSnapshotMinTimeInMillis|The interval time of transaction buffer takes a snapshot (in milliseconds).|5000|
+|transactionPendingAckLogIndexMinLag|MLPendingAckStore maintains a ConcurrentSkipListMap pendingAckLogIndex. PendingAckLogIndex stores the position in pendingAckStore as its value and saves a position used to determine whether the previous data can be cleaned up as a key. transactionPendingAckLogIndexMinLag is used to configure the minimum lag between indexes (keys).|500|

Review Comment:
   ```suggestion
   |transactionPendingAckLogIndexMinLag| The minimum lag between transaction pendingAck log indexes (keys). It can be used to determine the cleanup frequency of transaction pendingAck logs. Setting a larger lag leads to more consumption of hard disk resources; setting a smaller lag leads to more memory consumption. |500|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] momo-jun commented on a diff in pull request #15614: [feature][doc][config]Add missing transaction config in standalone.conf and broker.conf

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15614:
URL: https://github.com/apache/pulsar/pull/15614#discussion_r874412641


##########
site2/docs/reference-configuration.md:
##########
@@ -338,8 +338,12 @@ brokerServiceCompactionThresholdInBytes| If the estimated backlog size is greate
 |replicationProducerQueueSize| Replicator producer queue size                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |1000|
 |replicatorPrefix| Replicator prefix used for replicator producer name and cursor name pulsar.repl                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ||
 |transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |3000|
-|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |true|
-|transactionMetadataStoreProviderClassName|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |org.apache.pulsar.transaction.coordinator.impl.InMemTransactionMetadataStoreProvider|
+|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |false|
+|transactionMetadataStoreProviderClassName|The class name of transactionMetadataStoreProvider.|org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider|
+|transactionBufferSnapshotMaxTransactionCount|Transaction buffer takes a snapshot after the number of transaction operations reaches this value.|1000|
+|transactionBufferSnapshotMinTimeInMillis|The interval time of transaction buffer takes a snapshot (in milliseconds).|5000|

Review Comment:
   ```suggestion
   |transactionBufferSnapshotMinTimeInMillis|The interval between two snapshots that the transaction buffer takes (in milliseconds).|5000|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] momo-jun commented on a diff in pull request #15614: [feature][doc][config]Add missing transaction config in standalone.conf and broker.conf

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15614:
URL: https://github.com/apache/pulsar/pull/15614#discussion_r874419327


##########
site2/docs/reference-configuration.md:
##########
@@ -338,8 +338,12 @@ brokerServiceCompactionThresholdInBytes| If the estimated backlog size is greate
 |replicationProducerQueueSize| Replicator producer queue size                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |1000|
 |replicatorPrefix| Replicator prefix used for replicator producer name and cursor name pulsar.repl                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ||
 |transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |3000|
-|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |true|
-|transactionMetadataStoreProviderClassName|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |org.apache.pulsar.transaction.coordinator.impl.InMemTransactionMetadataStoreProvider|
+|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |false|
+|transactionMetadataStoreProviderClassName|The class name of transactionMetadataStoreProvider.|org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider|
+|transactionBufferSnapshotMaxTransactionCount|Transaction buffer takes a snapshot after the number of transaction operations reaches this value.|1000|
+|transactionBufferSnapshotMinTimeInMillis|The interval time of transaction buffer takes a snapshot (in milliseconds).|5000|
+|transactionPendingAckLogIndexMinLag|MLPendingAckStore maintains a ConcurrentSkipListMap pendingAckLogIndex. PendingAckLogIndex stores the position in pendingAckStore as its value and saves a position used to determine whether the previous data can be cleaned up as a key. transactionPendingAckLogIndexMinLag is used to configure the minimum lag between indexes (keys).|500|

Review Comment:
   ```suggestion
   |transactionPendingAckLogIndexMinLag| Used to configure the minimum lag between `PendingAckLogIndex` (keys). `PendingAckLogIndex` stores the position in `MLPendingAckStore` as its value and saves a position used to determine whether the previous data can be cleaned up as a key.|500|
   ```
   
   What's the measurement for the lag? milliseconds?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15614: [doc][config]Add missing transaction config in standalone.conf and broker.conf

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15614:
URL: https://github.com/apache/pulsar/pull/15614#discussion_r874263945


##########
conf/broker.conf:
##########
@@ -1395,7 +1395,7 @@ fileSystemURI=
 transactionCoordinatorEnabled=false
 transactionMetadataStoreProviderClassName=org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider
 
-# Transaction buffer take snapshot transaction count
+# Transaction Buffer will take a snapshot after the number of transaction operations reaches this value.

Review Comment:
   ```suggestion
   # Transaction buffer takes a snapshot after the number of transaction operations reaches this value.
   ```
   
   1. Write in the simple present tense as much as possible if you are covering facts that were, are, and forever shall be true. https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.e8uqh1awkcnp
   
   2. Why capitalize B for buffer?



##########
site2/docs/reference-configuration.md:
##########
@@ -338,8 +338,12 @@ brokerServiceCompactionThresholdInBytes| If the estimated backlog size is greate
 |replicationProducerQueueSize| Replicator producer queue size                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |1000|
 |replicatorPrefix| Replicator prefix used for replicator producer name and cursor name pulsar.repl                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ||
 |transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |3000|
-|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |true|
-|transactionMetadataStoreProviderClassName|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |org.apache.pulsar.transaction.coordinator.impl.InMemTransactionMetadataStoreProvider|
+|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |false|
+|transactionMetadataStoreProviderClassName||org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider|

Review Comment:
   The description is missing



##########
site2/docs/reference-configuration.md:
##########
@@ -338,8 +338,12 @@ brokerServiceCompactionThresholdInBytes| If the estimated backlog size is greate
 |replicationProducerQueueSize| Replicator producer queue size                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |1000|
 |replicatorPrefix| Replicator prefix used for replicator producer name and cursor name pulsar.repl                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ||
 |transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |3000|
-|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |true|
-|transactionMetadataStoreProviderClassName|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |org.apache.pulsar.transaction.coordinator.impl.InMemTransactionMetadataStoreProvider|
+|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |false|
+|transactionMetadataStoreProviderClassName||org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider|
+|transactionBufferSnapshotMaxTransactionCount|Transaction Buffer will take a snapshot after the number of transaction operations reaches this value.|1000|
+|transactionBufferSnapshotMinTimeInMillis|Transaction buffer take snapshot interval time (Unit : millisecond)|5000|
+|transactionPendingAckLogIndexMinLag|MLPendingAckStore maintains a ConcurrentSkipListMap pendingAckLogIndex. It stores the position in pendingAckStore as its value and saves a position used to determine whether the previous data can be cleaned up as a key. transactionPendingAckLogIndexMinLag is used to configure the minimum lag between indexes|500|

Review Comment:
   who `stores the position in pendingAckStore as its value and saves a position ....`? can you specify it explicitly? 



##########
site2/docs/reference-configuration.md:
##########
@@ -338,8 +338,12 @@ brokerServiceCompactionThresholdInBytes| If the estimated backlog size is greate
 |replicationProducerQueueSize| Replicator producer queue size                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |1000|
 |replicatorPrefix| Replicator prefix used for replicator producer name and cursor name pulsar.repl                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ||
 |transactionBufferClientOperationTimeoutInMills| The transaction buffer client's operation timeout in milliseconds.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |3000|
-|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |true|
-|transactionMetadataStoreProviderClassName|                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |org.apache.pulsar.transaction.coordinator.impl.InMemTransactionMetadataStoreProvider|
+|transactionCoordinatorEnabled| Whether to enable transaction coordinator in broker.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |false|
+|transactionMetadataStoreProviderClassName||org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider|
+|transactionBufferSnapshotMaxTransactionCount|Transaction Buffer will take a snapshot after the number of transaction operations reaches this value.|1000|
+|transactionBufferSnapshotMinTimeInMillis|Transaction buffer take snapshot interval time (Unit : millisecond)|5000|

Review Comment:
   ```suggestion
   |transactionBufferSnapshotMinTimeInMillis|The interval time of transaction buffer takes a snapshot (in milliseconds)|5000|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org