[GitHub] [hadoop] jojochuang commented on a change in pull request #3722: HADOOP-18025. Upgrade HBase version to 1.7.1 for hbase1 profile

[GitBox <gi...@apache.org>]

jojochuang commented on a change in pull request #3722:
URL: https://github.com/apache/hadoop/pull/3722#discussion_r758165926



##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-client/src/main/java/org/apache/hadoop/yarn/server/timelineservice/storage/reader/EntityTypeReader.java
##########
@@ -158,7 +158,9 @@ protected void validateParams() {
   private ResultScanner getResult(Configuration hbaseConf, Connection conn,
       FilterList filterList, byte[] startPrefix, byte[] endPrefix)
       throws IOException {
-    Scan scan = new Scan(startPrefix, endPrefix);
+    Scan scan = new Scan();
+    scan.withStartRow(startPrefix);
+    scan.withStopRow(endPrefix);

Review comment:
       nit: it would be the best it make it as the following:
   scan.withStartRow()
             .withStopRow()
             .setFilter()
             .setSmall()




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org