You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/15 04:10:06 UTC
[GitHub] [airflow] pastanton opened a new pull request, #25083: Update sql_to_s3.py
pastanton opened a new pull request, #25083:
URL: https://github.com/apache/airflow/pull/25083
When doing the type check, convert dataframe columns object to str.
This avoids errors when converting from df to parquet, allowing for this simple SQL->S3 operator to be used with most queries - without having to modify the SQL to avoid types pandas doesn't by like by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25083: SqlToS3Operator: change column type from object to str in dataframe
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25083:
URL: https://github.com/apache/airflow/pull/25083#issuecomment-1188066217
:tada:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pastanton commented on pull request #25083: SqlToS3Operator: change column type from object to str in dataframe
Posted by GitBox <gi...@apache.org>.
pastanton commented on PR #25083:
URL: https://github.com/apache/airflow/pull/25083#issuecomment-1187894122
Shortened character length of a comment to comply with PEP8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25083: SqlToS3Operator: change column type from object to str in dataframe
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25083:
URL: https://github.com/apache/airflow/pull/25083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25083: Update sql_to_s3.py
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25083:
URL: https://github.com/apache/airflow/pull/25083#issuecomment-1185153319
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pastanton commented on pull request #25083: SqlToS3Operator: change column type from object to str in dataframe
Posted by GitBox <gi...@apache.org>.
pastanton commented on PR #25083:
URL: https://github.com/apache/airflow/pull/25083#issuecomment-1186334798
Some tests failed due to my renaming the private method. That should be fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25083: SqlToS3Operator: change column type from object to str in dataframe
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25083:
URL: https://github.com/apache/airflow/pull/25083#issuecomment-1188065929
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org