You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2017/04/26 23:38:23 UTC
Review Request 58758: Added secret to Image.{docker,
appc} and ContainerInfo.volume.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58758/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
Added secret to Image.{docker,appc} and ContainerInfo.volume.
Diffs
-----
include/mesos/mesos.proto eaa2d2ac697cfc4f5aa56db0fb37363339608f43
Diff: https://reviews.apache.org/r/58758/diff/1/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 58758: Added secret to Image.{docker,
appc} and ContainerInfo.volume.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58758/#review173253
-----------------------------------------------------------
Please address the comments and add the same changes to v1/mesos.proto
include/mesos/mesos.proto
Lines 2112-2113 (patched)
<https://reviews.apache.org/r/58758/#comment246296>
The change on `Image` is already merged. Please discard this part.
include/mesos/mesos.proto
Lines 2216 (patched)
<https://reviews.apache.org/r/58758/#comment246297>
Could we add some comments?
- Gilbert Song
On April 26, 2017, 4:38 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58758/
> -----------------------------------------------------------
>
> (Updated April 26, 2017, 4:38 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added secret to Image.{docker,appc} and ContainerInfo.volume.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto eaa2d2ac697cfc4f5aa56db0fb37363339608f43
>
>
> Diff: https://reviews.apache.org/r/58758/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 58758: Added secret to Volume protobuf.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58758/#review173382
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On April 28, 2017, 11:49 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58758/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 11:49 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The volume/secret isolator will use a secret-fetcher module (third-party or internal) to download the secret and makes it available at container_path.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 46bb7813cc402f2a71879d26d4bbc62abd852d52
> include/mesos/v1/mesos.proto f7c05a82f8265aedc0bd8fd20dd30e21af46e775
>
>
> Diff: https://reviews.apache.org/r/58758/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 58758: Added secret to Volume protobuf.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58758/
-----------------------------------------------------------
(Updated April 28, 2017, 2:49 p.m.)
Review request for mesos and Gilbert Song.
Summary (updated)
-----------------
Added secret to Volume protobuf.
Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418
Repository: mesos
Description (updated)
-------
The volume/secret isolator will use a secret-fetcher module (third-party or internal) to download the secret and makes it available at container_path.
Diffs (updated)
-----
include/mesos/mesos.proto 46bb7813cc402f2a71879d26d4bbc62abd852d52
include/mesos/v1/mesos.proto f7c05a82f8265aedc0bd8fd20dd30e21af46e775
Diff: https://reviews.apache.org/r/58758/diff/2/
Changes: https://reviews.apache.org/r/58758/diff/1-2/
Testing
-------
Thanks,
Kapil Arya